Re: Migrate to jakarta namespace

[Thomas Andraschko <an...@gmail.com>]

Hi!

why do we have 3 implementations in the classpath?

also, what about the current branches? master, bv2, bval-2.x are all 2.0.x?



Am Mo., 30. Jan. 2023 um 20:33 Uhr schrieb Jean-Louis Monteiro <
jlmonteiro@tomitribe.com>:

> Hey Thomas,
>
> I was looking to help and push some boilerplate for you as I will be
> unavailable for the rest of the week.
>
> I got something that runs under Jakarta but I don't understand this test
>
> https://github.com/apache/bval/blob/master/bval-jsr/src/test/java/org/apache/bval/jsr/DefaultMessageInterpolatorTest.java#L109
>
> How can the returned instance be always an instance of the factory set?
> To me it works for elFactory == null which is an edge case. And it also
> works for one and only one of the implementations tested. This is because
> by default the ExpressionFactory.newInstance() will always look first at
> the service loader returned value and then the system property. As we have
> 3 implementations in the classpath, there will always be one implementation
> found, and always the same, isn't it?
> It might be an API change so the system property isn't checked upfront.
>
> Any thoughts?
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Jan 30, 2023 at 4:24 PM Jean-Louis Monteiro <
> jlmonteiro@tomitribe.com> wrote:
>
> > Do you want me to start doing some migration and push it to help you?
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Jan 30, 2023 at 4:23 PM Thomas Andraschko <
> > andraschko.thomas@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> i will work on it, probably this or next week.
> >>
> >> Am Mo., 30. Jan. 2023 um 16:16 Uhr schrieb Jean-Louis Monteiro <
> >> jlmonteiro@tomitribe.com>:
> >>
> >> > Hey Thomas and all,
> >> >
> >> > Did you get a chance to work on the migration?
> >> > I've got a few hours I could dedicate to do the bulk migration and
> >> upgrade
> >> > the APIs + TCKs (after creating the maintenance branch of course).
> >> > --
> >> > Jean-Louis Monteiro
> >> > http://twitter.com/jlouismonteiro
> >> > http://www.tomitribe.com
> >> >
> >> >
> >> > On Thu, Jan 12, 2023 at 10:09 AM Romain Manni-Bucau <
> >> rmannibucau@gmail.com
> >> > >
> >> > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > @Francesco, bval has a jakarta version in 2.0.6 (same as openjpa) -
> >> if it
> >> > > helps.
> >> > > @Thomas: never saw it used nor any user feedback on the list so
> >> assuming
> >> > > they are not used at all.
> >> > >
> >> > > Romain Manni-Bucau
> >> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> > > <https://rmannibucau.metawerx.net/> | Old Blog
> >> > > <http://rmannibucau.wordpress.com> | Github <
> >> > > https://github.com/rmannibucau> |
> >> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> > > <
> >> > >
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > > >
> >> > >
> >> > >
> >> > > Le jeu. 12 janv. 2023 à 09:06, Thomas Andraschko <
> >> > > andraschko.thomas@gmail.com> a écrit :
> >> > >
> >> > > > what about the extras, romain? are they unused?
> >> > > >
> >> > > > Am Do., 12. Jan. 2023 um 08:57 Uhr schrieb Francesco Chicchiriccò
> <
> >> > > > ilgrosso@apache.org>:
> >> > > >
> >> > > > > Hi there,
> >> > > > > not a dev here, just chiming in because we're moving Syncope to
> >> > Spring
> >> > > > > Boot 3 / Jakarta and had to replace our BVal dependencies with
> >> > > Hibernate
> >> > > > > Validator's just because of namespace issues.
> >> > > > >
> >> > > > > Just my 2c: speaking from experience with OpenJPA, shading works
> >> but
> >> > a
> >> > > > > clean new version would help with usability.
> >> > > > > Either way, making BVal compatible with Jakarta is something
> that
> >> > would
> >> > > > > definitely help users stick with it and not to be forced to
> >> change.
> >> > > > >
> >> > > > > Thanks for your work with BVal, everyone.
> >> > > > > Regards.
> >> > > > >
> >> > > > > On 2023/01/10 12:46:49 Thomas Andraschko wrote:
> >> > > > > > Hi,
> >> > > > > >
> >> > > > > > i would like to finally migrate BVal to the jakarta namespace.
> >> > > > > > WDYT?
> >> > > > > > I would create a 2.0.x branch and set master to
> 3.0.0-SNAPSHOT.
> >> > > > > >
> >> > > > > > I know that shading has benefits but as we dont have that many
> >> > > releases
> >> > > > > > each year, i dont think its a big problem for us to handle
> >> master
> >> > > and a
> >> > > > > > second branch if we really need a release.
> >> > > > > > Also check our JIRA - we dont have any recent bug reports.
> >> > > > > >
> >> > > > > > Best regards,
> >> > > > > > Thomas
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>