You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/05/10 18:33:56 UTC

Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59151/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.


Bugs: AMBARI-20972
    https://issues.apache.org/jira/browse/AMBARI-20972


Repository: ambari


Description
-------

The workflows displayed on the worflow designer view dashboard are not sortable. The ability to sort via Name, Status, User, Created Time, End Time and jobId should be included


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 01eb4ea 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 86ab5a5 


Diff: https://reviews.apache.org/r/59151/diff/1/


Testing
-------

Tested manually


File Attachments
----------------

sort
  https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG


Thanks,

Anita Jebaraj


Re: Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59151/#review174614
-----------------------------------------------------------



I guess its a all client side. Would it not confuse the users. Oozie support for server side pagination is not there. This was a requiremnt long time backe , but we consciously decided not to do it. Ideal would be if ooze supports pagination on server side and the UI integrates with it.

- belliraj hb


On May 10, 2017, 6:33 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59151/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 6:33 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20972
>     https://issues.apache.org/jira/browse/AMBARI-20972
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The workflows displayed on the worflow designer view dashboard are not sortable. The ability to sort via Name, Status, User, Created Time, End Time and jobId should be included
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 01eb4ea 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 86ab5a5 
> 
> 
> Diff: https://reviews.apache.org/r/59151/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> sort
>   https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59151/#review175504
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On May 10, 2017, 6:33 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59151/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 6:33 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20972
>     https://issues.apache.org/jira/browse/AMBARI-20972
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The workflows displayed on the worflow designer view dashboard are not sortable. The ability to sort via Name, Status, User, Created Time, End Time and jobId should be included
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 01eb4ea 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 86ab5a5 
> 
> 
> Diff: https://reviews.apache.org/r/59151/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> sort
>   https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>