[GitHub] [orc] omalley commented on a change in pull request #508: ORC-629: PPD: Floating point NaN is not transitive across comparisons

[GitBox <gi...@apache.org>]

omalley commented on a change in pull request #508:
URL: https://github.com/apache/orc/pull/508#discussion_r474314994



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -495,6 +495,14 @@ static TruthValue evaluatePredicateProto(OrcProto.ColumnStatistics statsProto,
                    " include ORC-517. Writer version: {}",
           predicate.getColumnName(), writerVersion);
       return TruthValue.YES_NO_NULL;
+    } else if (category == TypeDescription.Category.DOUBLE) {
+      DoubleColumnStatistics dstas = (DoubleColumnStatistics) cs;
+      if (!Double.isFinite(dstas.getMinimum()) || !Double.isFinite(dstas.getMaximum())

Review comment:
       This check is overly broad. Positive and Negative infinity work fine with min and max. You should just check for NaN in the sum.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org