You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2017/08/02 19:42:31 UTC
[GitHub] storm pull request #2257: STORM-2673: add support for prioritizing nodes in ...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2257
STORM-2673: add support for prioritizing nodes in scheduling
I really would like feedback on the configs and if it makes since to modify other schedulers to support this too.
Config:
I thought about using regexs for nodes instead of just a host name. Would that be better? Would it make it simple for someone to prefer a large section of a cluster and essentially abuse the feature?
Other Schedulers:
The isolation scheduler possibly, where we could resort The HostAssignableSlots if the topology want to prioritize one host over another. And then sort them back if they don't
The even scheduler is a little odd as it feels completely against what it stands for. It would almost turn it into an odd hybrid with the isolation scheduler.
MT scheduler is so complex at this point I could do it, but only if someone really wants it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2673
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2257
----
commit 9b4c30dab0bc2828c4675d94a1e834a092ae8635
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-08-02T19:21:11Z
STORM-2673: add support for prioritizing nodes in scheduling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2257: STORM-2673: add support for prioritizing nodes in schedul...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2257
+1 for the change.
@revans2
Regarding accepting regex, since its purpose is only debug, I don't feel we need to apply regex for now. If we are unsure and would like to hear others' voices then we can initiate poll in users@.
Regarding applying other schedulers as well, I guess it would be better to do that, but you can still file new issues addressing them and let this be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2257: STORM-2673: add support for prioritizing nodes in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---