You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@griffin.apache.org by gu...@apache.org on 2018/06/22 04:11:37 UTC
incubator-griffin git commit: refactor test codes in service/src/test/java/org/apache/griffin/core/…
Repository: incubator-griffin
Updated Branches:
refs/heads/master 0249ac83c -> 0ae391057
refactor test codes in service/src/test/java/org/apache/griffin/core/…
…util/PropertiesUtilTest.java
1.remove assert keyword instead of Junit Assert class
Author: Eugene <to...@163.com>
Closes #323 from toyboxman/refactor/testcases.
Project: http://git-wip-us.apache.org/repos/asf/incubator-griffin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-griffin/commit/0ae39105
Tree: http://git-wip-us.apache.org/repos/asf/incubator-griffin/tree/0ae39105
Diff: http://git-wip-us.apache.org/repos/asf/incubator-griffin/diff/0ae39105
Branch: refs/heads/master
Commit: 0ae391057d58a57404b74b7f3e46b652b5b6dd3a
Parents: 0249ac8
Author: Eugene <to...@163.com>
Authored: Fri Jun 22 12:11:13 2018 +0800
Committer: William Guo <gu...@apache.org>
Committed: Fri Jun 22 12:11:13 2018 +0800
----------------------------------------------------------------------
.../java/org/apache/griffin/core/util/PropertiesUtilTest.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/0ae39105/service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java
----------------------------------------------------------------------
diff --git a/service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java b/service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java
index e0ffbb6..957f97b 100644
--- a/service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java
+++ b/service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java
@@ -27,6 +27,7 @@ import java.util.Properties;
import static org.apache.griffin.core.util.PropertiesUtil.getConf;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
public class PropertiesUtilTest {
@@ -50,7 +51,7 @@ public class PropertiesUtilTest {
String defaultPath = "/" + name;
String location = "src/test/resources";
Properties properties = getConf(name, defaultPath, location);
- assert properties != null;
+ assertNotNull(properties);
}
@Test
@@ -59,7 +60,7 @@ public class PropertiesUtilTest {
String defaultPath = "/" + name;
String location = "src/main";
Properties properties = getConf(name, defaultPath, location);
- assert properties != null;
+ assertNotNull(properties);
}
@Test
@@ -67,7 +68,7 @@ public class PropertiesUtilTest {
String name = "sparkJob.properties";
String defaultPath = "/" + name;
Properties properties = getConf(name, defaultPath, null);
- assert properties != null;
+ assertNotNull(properties);
}
}
\ No newline at end of file