You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/20 11:23:02 UTC

[GitHub] cloud-fan commented on a change in pull request #23339: [MINOR][SQL]Locality does not need to be implemented

cloud-fan commented on a change in pull request #23339: [MINOR][SQL]Locality does not need to be implemented
URL: https://github.com/apache/spark/pull/23339#discussion_r243237864
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala
 ##########
 @@ -51,7 +51,6 @@ class HadoopFileLinesReader(
       new Path(new URI(file.filePath)),
       file.start,
       file.length,
-      // TODO: Implement Locality
 
 Review comment:
   maybe we should leave some comment to explain where the locality is decided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org