You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fucun Chu (Code Review)" <ge...@cloudera.org> on 2021/01/05 12:13:03 UTC
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Fucun Chu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16922
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
- Minor edit
Change-Id: I3d422889c433062456748a953b33e3d43799be14
---
M docs/impala.ditamap
A docs/topics/impala_join_rows_produced_limit.xml
2 files changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/16922/1
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 1
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 2: Code-Review+1
Doing a +1 and am also cc-ing Shajini who does the documentation for Impala. I can +2 after she has looked it over.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Jan 2021 21:18:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Shajini Thayasingh has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/2/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/2/docs/topics/impala_join_rows_produced_limit.xml@43
PS2, Line 43: rows produced by a join node such that runaway join queries can be prevented. A query
The <codeph>JOIN_ROWS_PRODUCED_LIMIT</codeph> query option limits the number of join rows produced by a join node and is used to prevent runaway join queries.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jan 2021 18:50:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/617/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 01:56:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
- Minor edit
Change-Id: I3d422889c433062456748a953b33e3d43799be14
Reviewed-on: http://gerrit.cloudera.org:8080/16922
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>
---
M docs/impala.ditamap
A docs/topics/impala_join_rows_produced_limit.xml
2 files changed, 78 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Aman Sinha: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 5
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/1/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/1/docs/topics/impala_join_rows_produced_limit.xml@44
PS1, Line 44: any one of the
> To be more accurate: ...when any one of the joins in the query produces mo
Done
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 Jan 2021 03:35:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 07:14:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/616/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 Jan 2021 03:42:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/3/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/3/docs/topics/impala_join_rows_produced_limit.xml@46
PS3, Line 46: <codeph>JOIN_ROWS_PRODUCED_LIMIT</codeph> option.
I should have mentioned this in the first pass .. but just realized that the actual row count could slightly exceed the limit. This is a useful piece of info for the docs. Could you add a sentence ..something like: 'This limit is checked periodically, so it is possible that the actual number of rows produced may be slightly higher than the limit'.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 02:21:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/612/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 1
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 12:13:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16922
to look at the new patch set (#2).
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
- Minor edit
Change-Id: I3d422889c433062456748a953b33e3d43799be14
---
M docs/impala.ditamap
A docs/topics/impala_join_rows_produced_limit.xml
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/16922/2
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/617/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 01:49:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Shajini Thayasingh, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16922
to look at the new patch set (#4).
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
- Minor edit
Change-Id: I3d422889c433062456748a953b33e3d43799be14
---
M docs/impala.ditamap
A docs/topics/impala_join_rows_produced_limit.xml
2 files changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/16922/4
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/616/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 Jan 2021 03:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/2/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/2/docs/topics/impala_join_rows_produced_limit.xml@43
PS2, Line 43: rows produced by a join node and is used to prevent runaway join queries. A query
> The <codeph>JOIN_ROWS_PRODUCED_LIMIT</codeph> query option limits the numbe
Done
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 01:49:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Shajini Thayasingh, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16922
to look at the new patch set (#3).
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
- Minor edit
Change-Id: I3d422889c433062456748a953b33e3d43799be14
---
M docs/impala.ditamap
A docs/topics/impala_join_rows_produced_limit.xml
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/16922/3
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/3/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/3/docs/topics/impala_join_rows_produced_limit.xml@46
PS3, Line 46: <codeph>JOIN_ROWS_PRODUCED_LIMIT</codeph> option.
> I should have mentioned this in the first pass .. but just realized that th
Done
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 06:22:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/618/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 06:22:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/618/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jan 2021 06:29:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16922/1/docs/topics/impala_join_rows_produced_limit.xml
File docs/topics/impala_join_rows_produced_limit.xml:
http://gerrit.cloudera.org:8080/#/c/16922/1/docs/topics/impala_join_rows_produced_limit.xml@44
PS1, Line 44: its execution
To be more accurate: ...when any one of the joins in the query produces more rows (totaled across all instances of that join) produces ...
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 1
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jan 2021 16:44:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 )
Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/612/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d422889c433062456748a953b33e3d43799be14
Gerrit-Change-Number: 16922
Gerrit-PatchSet: 1
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 12:19:51 +0000
Gerrit-HasComments: No