You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/12/18 21:46:41 UTC

[GitHub] [libcloud] Kami opened a new pull request #1391: Fix a regression with "get_driver()" function not working with string values

Kami opened a new pull request #1391: Fix a regression with "get_driver()" function not working with string values
URL: https://github.com/apache/libcloud/pull/1391
 
 
   This pull request fixes a regression which was inadvertently introduced in #1306 as part of MyPy refactoring changes.
   
   That change broke ``get_driver()`` method so it doesn't work anymore if ``provider`` argument is a string and not an ``Provider.FOO`` enum type.
   
   Only officially supported and recommended approach still is to use ``Provider.FOO`` enum constants, but since string notation was supported in the past and likely a lot of the existing code relies on it, we should still support (at least until we have the time to properly officially deprecate and remove support for it).
   
   Resolves #1390.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services