[GitHub] [maven-shade-plugin] kriegaex commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

[GitBox <gi...@apache.org>]

kriegaex commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882959624


   @Tibor17, I see no reason to squash the commits, because they are doing separate things. I see you use separate commits in one PR too, e.g. lately in Surefire, and I think small commits are a good practice. If ever you need to revert something, chances are that you can revert a single commit instead of a part of a big one. Bisecting bugs is easier, too. Furthermore, in this case there are two separate committers. Squashing everything into one commit would mean to disrespect other people's contribution and copyright. So I am not confident squasing @rmannibucau's commit into mine. The 4 commits so the following:
     1. Adress the core issue
     2. Add an integration test
     3. The other committer refactored something because he did not like my use of thread-local.
     4. I refactored something in his commit because of suboptimal naming.
   
   This code evolution should remain visible and traceable, IMO. If you insist, I can squash 1+2, but I would rather not. Not a big commit history is a problem, big commits are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org