[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #11340: feat: adding feature flags to escape/hide html in markdown

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #11340:
URL: https://github.com/apache/incubator-superset/pull/11340#discussion_r509547979



##########
File path: superset/config.py
##########
@@ -308,6 +308,12 @@ def _try_json_readsha(  # pylint: disable=unused-argument
     "TAGGING_SYSTEM": False,
     "SQLLAB_BACKEND_PERSISTENCE": False,
     "LISTVIEWS_DEFAULT_CARD_VIEW": False,
+
+    # When set to True, this flag allows display of HTML tags in Markdown components
+    "DISPLAY_MARKDOWN_HTML": True,
+
+    # When True, this escapes HTML (rather than rendering it) in Markdown components
+    "ESCAPE_MARKDOWN_HTML": False,

Review comment:
       Security-first default settings would be my preferred approach. Is there a reason why the default here can't be secure out of the box?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org