You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/24 14:34:32 UTC

[GitHub] tillrohrmann opened a new pull request #6742: [FLINK-10400] Fail JobResult if application finished in CANCELED or FAILED state

tillrohrmann opened a new pull request #6742: [FLINK-10400] Fail JobResult if application finished in CANCELED or FAILED state
URL: https://github.com/apache/flink/pull/6742
 
 
   ## What is the purpose of the change
   
   When generating a `JobExecutionResult` from a `JobResult`, we fail the conversion if the application status was not `SUCCEEDED`.
   
   In case of the CANCELED state, the client will throw an JobCancellationException.
   In case of the FAILED state, the client will throw an JobExecutionException.
   
   ## Brief change log
   
   - Add `ApplicationStatus` field to `JobResult`
   - Throw `JobCancellationException` if `ApplicationStatus` was `CANCELED`
   - Throw `JobExecutionException` if `ApplicationStatus` was `FAILED`
   
   ## Verifying this change
   
   - Added `JobResultTest#testCancelledJobIsFailureResult`, `#testFailedJobIsFailureResult`, `#testCancelledJobThrowsJobCancellationException` and `#testFailedJobThrowsJobExecutionException`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services