[cordova-fetch] branch master updated: CB-14173 Fix cordova add --link (#26)

[ra...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-fetch.git


The following commit(s) were added to refs/heads/master by this push:
     new f17ccf7  CB-14173 Fix cordova <platform|plugin> add --link (#26)
f17ccf7 is described below

commit f17ccf70448a4822ba2ed0434dd39b905822321a
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Thu Jun 28 18:27:47 2018 +0200

    CB-14173 Fix cordova <platform|plugin> add --link (#26)
    
    This drops support for the untested and undocumented `link` option
    which when set, caused `npm link` to be run instead of `npm install`.
    However, the installed package's name cannot be extracted from the
    output of `npm link`. Thus we failed in that case.
    
    Now we always run `npm install` instead. This works for the use case of
    `cordova <platform|plugin> add --link` since packages identified by a
    local path are installed as symbolic links by npm.
---
 index.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/index.js b/index.js
index dfa51f7..5eb0831 100644
--- a/index.js
+++ b/index.js
@@ -69,8 +69,7 @@ function installPackage (target, dest, opts) {
 function npmArgs (target, userOptions) {
     const opts = Object.assign({ production: true }, userOptions);
 
-    const operation = opts.link ? 'link' : 'install';
-    const args = [operation, target];
+    const args = ['install', target];
 
     if (opts.production) {
         args.push('--production');


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org