[GitHub] [guacamole-client] necouchman commented on pull request #599: PROTOCOL_SSH 부분 번역 완료

[GitBox <gi...@apache.org>]

necouchman commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-792714533


   @from97 
   
   Thank you very much for contributing this to the project - we're always happy to have help in the translation area!
   
   A few things that need to be adjusted, here, before moving forward:
   * All pull requests need a matching Issue created in JIRA to track the improvement/bug.
   * Once the JIRA issue is created, both the pull request and all commits need to be tagged with the JIRA issue (GUACAMOLE-XXXX:) - see other open pull requests for examples of this.
   * You have a lot of commits in this pull request, and they can probably be squashed into a smaller number of commits, with meaningful messages.
   * While you did translate the main webapp file, each of the authentication extensions has its own translation file, so it might be worth looking at those and adding those translations while you're at it, if you are so inclined.
   
   Thanks, again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org