You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2016/11/14 16:50:18 UTC
[GitHub] incubator-geode pull request #283: GEODE-2098: Moved gfsh history file locat...
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/283
GEODE-2098: Moved gfsh history file location from .gemfire to .geode
Made the code changes and added a test for the same.
Following Test is failing with precheckin, but works fine when ran individually.
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/incubator-geode feature/GEODE-2098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit 6e1377a0f3f32aef279e9cbea3741c90aad95f30
Author: adongre <av...@ampool.io>
Date: 2016-11-13T14:11:44Z
GEODE-2098: Moved gfsh history file location from .gemfire to .geode
Made the code changes and added a test for the same.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
@kirklund
What OS does DiskSpaceLimitIntegrationTest fail on for you?
[ Avinash ] Linux
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Since Geode 1.0 released using .gemfire history file, we should probably read and use .gemfire if .geode does not exist. If both files exist then .geode should take precedence.
What OS does DiskSpaceLimitIntegrationTest fail on for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Thanks @kirklund @metatype @upthewaterspout. Do I need to mark the JIRA for release notes ? If not I will merge this PR, please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
closing the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Agreed. This could be handled in a release note: \u201cIf you want to preserve your gfsh history, please copy\u2026\u201d
Anthony
> On Nov 14, 2016, at 10:57 AM, Dan Smith <no...@github.com> wrote:
>
> IMO losing your gfsh history on an upgrade is probably not a big deal.
>
> \u2014
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <https://github.com/apache/incubator-geode/pull/283#issuecomment-260427020>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACqT2dEBRv5RJyZjnBFGW1o76-yAooPwks5q-K7_gaJpZM4KxirC>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/283
I recommend discussing backwards compatibility of .gemfire vs .geode directory (which contains gfsh history file) on the dev list. I don't really feel strongly one way or the other (supporting .gemfire vs just a hard switch to .geode). Dev list is good place to discuss backwards compatibility though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/283
I tried to pull this in but I get an error message about the branch not existing:
fatal: Couldn't find remote ref feature/GEODE-2098
Looks like the pull request is still open, but the branch has been destroyed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/283
+1 looks ready to push to develop.
Once it's committed on develop, then mark the Jira ticket Resolved (not Closed) and Fix Version(s) should say 1.1.0-incubating. When 1.1.0 is released, all Resolved tickets are moved to Closed (all such tickets will be part of release notes automatically I think).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/283
IMO losing your gfsh history on an upgrade is probably not a big deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
Thanks @kirklund, @metatype I have followed the process from https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Please do let me know if everything is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #283: GEODE-2098: Moved gfsh history file locat...
Posted by davinash <gi...@git.apache.org>.
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---