You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "MasterJH5574 (via GitHub)" <gi...@apache.org> on 2023/04/17 01:00:16 UTC

[GitHub] [tvm] MasterJH5574 opened a new pull request, #14642: [MetaSchedule] PostProc not rewriting unroll for purely spatial block

MasterJH5574 opened a new pull request, #14642:
URL: https://github.com/apache/tvm/pull/14642

   This PR adds a behavior to the MetaSchedule post-processor RewriteParallelVectorizeUnroll, so that it does not annotate spatial blocks with the unroll annotation.
   
   This is because the optimization for spatial blocks (standalone in a GPU kernel, for example) can be done by purely thread binding. As a result, annotating loop unrolling for spatial blocks does not help. In some case where the unroll factor is very large (e.g., 512 or 1024), unrolling the spatial blocks will consume much time during the kernel compilation and introduces unnecessary overhead.
   
   Therefore, we turn off the behavior of unrolling spatial blocks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14642: [MetaSchedule] PostProc not rewriting unroll for purely spatial block

Posted by "tqchen (via GitHub)" <gi...@apache.org>.

tqchen merged PR #14642:
URL: https://github.com/apache/tvm/pull/14642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14642: [MetaSchedule] PostProc not rewriting unroll for purely spatial block

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #14642:
URL: https://github.com/apache/tvm/pull/14642#issuecomment-1510548970

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @ibsidorenko <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org