You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ac...@apache.org on 2008/07/21 15:00:45 UTC

svn commit: r678406 - /xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java

Author: acumiskey
Date: Mon Jul 21 06:00:45 2008
New Revision: 678406

URL: http://svn.apache.org/viewvc?rev=678406&view=rev
Log:
Better to remove on finally rather than the try block.

Modified:
    xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java

Modified: xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java?rev=678406&r1=678405&r2=678406&view=diff
==============================================================================
--- xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java (original)
+++ xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java Mon Jul 21 06:00:45 2008
@@ -112,11 +112,12 @@
         try {
             raFile.close();
             tempFile.delete();
+        } catch (IOException e) {
+            log.error("Failed to close temporary file");
+        } finally {
             synchronized (cacheMap) {
                 cacheMap.remove(id); // remove ourselves from the cache map
             }
-        } catch (IOException e) {
-            log.error("Failed to close temporary file");
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org