[GitHub] [kyuubi] runzhliu commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster

["runzhliu (via GitHub)" <gi...@apache.org>]

runzhliu commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099834131


##########
.github/workflows/master.yml:
##########
@@ -394,15 +394,12 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
       - name: Setup Minikube
-        uses: manusa/actions-setup-minikube@v2.7.2
-        with:
-          minikube version: 'v1.28.0'
-          kubernetes version: 'v1.25.4'
-          github token: ${{ secrets.GITHUB_TOKEN }}
-          driver: docker
-          start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU --force --cpus 2 --memory 4096'
+        run: |
+          # https://minikube.sigs.k8s.io/docs/start/
+          curl -LO https://github.com/kubernetes/minikube/releases/download/v1.29.0/minikube-linux-amd64

Review Comment:
   Good point!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org