You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 19:29:43 UTC
[GitHub] [flink] xuefuz commented on a change in pull request #10296:
[FLINK-14691][table]Add use/create/drop/alter database operation and
support it in flink/blink planner
xuefuz commented on a change in pull request #10296: [FLINK-14691][table]Add use/create/drop/alter database operation and support it in flink/blink planner
URL: https://github.com/apache/flink/pull/10296#discussion_r353377896
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -116,6 +116,27 @@ public void dropDatabase(String databaseName, boolean ignoreIfNotExists)
// Make sure the database is empty
if (isDatabaseEmpty(databaseName)) {
databases.remove(databaseName);
+ } else if (cascade) {
+ // delete all tables in this database and then delete the database.
Review comment:
Nit: => delete all tables and functions ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services