[GitHub] [spark] zhengruifeng opened a new pull request #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

[GitBox <gi...@apache.org>]

zhengruifeng opened a new pull request #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations
URL: https://github.com/apache/spark/pull/25324
 
 
   ## What changes were proposed in this pull request?
   some cleanup and tiny optimization
   1, since the `transformImpl` method in the .mllib side is no longer used in the .ml side, the scope should be limited;
   2, in the `hashUDF`, val `numOfFeatures` is never used;
   3, in the udf, it is inefficient to involve param getter (`$(numFeatures)`/`$(binary)`) directly or via method `indexOf` ((`$(numFeatures)`) . instead, the getter should be called outside of the udf;
   
   ## How was this patch tested?
   existing suites

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org