You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/01/22 08:07:46 UTC
svn commit: r1436768 [8/13] - in /commons/proper/lang/trunk/src:
main/java/org/apache/commons/lang3/
main/java/org/apache/commons/lang3/builder/
main/java/org/apache/commons/lang3/concurrent/
main/java/org/apache/commons/lang3/event/ main/java/org/apac...
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/event/EventUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/event/EventUtils.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/event/EventUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/event/EventUtils.java Tue Jan 22 07:07:42 2013
@@ -45,7 +45,7 @@ public class EventUtils {
*
* @throws IllegalArgumentException if the object doesn't support the listener type
*/
- public static <L> void addEventListener(Object eventSource, Class<L> listenerType, L listener) {
+ public static <L> void addEventListener(final Object eventSource, final Class<L> listenerType, final L listener) {
try {
MethodUtils.invokeMethod(eventSource, "add" + listenerType.getSimpleName(), listener);
} catch (NoSuchMethodException e) {
@@ -72,8 +72,8 @@ public class EventUtils {
* @param eventTypes the event types (method names) from the listener interface (if none specified, all will be
* supported)
*/
- public static <L> void bindEventsToMethod(Object target, String methodName, Object eventSource,
- Class<L> listenerType, String... eventTypes) {
+ public static <L> void bindEventsToMethod(final Object target, final String methodName, final Object eventSource,
+ final Class<L> listenerType, final String... eventTypes) {
final L listener = listenerType.cast(Proxy.newProxyInstance(target.getClass().getClassLoader(),
new Class[] { listenerType }, new EventBindingInvocationHandler(target, methodName, eventTypes)));
addEventListener(eventSource, listenerType, listener);
@@ -91,7 +91,7 @@ public class EventUtils {
* @param methodName the name of the method to be invoked
* @param eventTypes the names of the supported event types
*/
- EventBindingInvocationHandler(final Object target, final String methodName, String[] eventTypes) {
+ EventBindingInvocationHandler(final Object target, final String methodName, final String[] eventTypes) {
this.target = target;
this.methodName = methodName;
this.eventTypes = new HashSet<String>(Arrays.asList(eventTypes));
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedException.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedException.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedException.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedException.java Tue Jan 22 07:07:42 2013
@@ -105,7 +105,7 @@ public class ContextedException extends
*
* @param message the exception message, may be null
*/
- public ContextedException(String message) {
+ public ContextedException(final String message) {
super(message);
exceptionContext = new DefaultExceptionContext();
}
@@ -117,7 +117,7 @@ public class ContextedException extends
*
* @param cause the underlying cause of the exception, may be null
*/
- public ContextedException(Throwable cause) {
+ public ContextedException(final Throwable cause) {
super(cause);
exceptionContext = new DefaultExceptionContext();
}
@@ -130,7 +130,7 @@ public class ContextedException extends
* @param message the exception message, may be null
* @param cause the underlying cause of the exception, may be null
*/
- public ContextedException(String message, Throwable cause) {
+ public ContextedException(final String message, final Throwable cause) {
super(message, cause);
exceptionContext = new DefaultExceptionContext();
}
@@ -142,7 +142,7 @@ public class ContextedException extends
* @param cause the underlying cause of the exception, may be null
* @param context the context used to store the additional information, null uses default implementation
*/
- public ContextedException(String message, Throwable cause, ExceptionContext context) {
+ public ContextedException(final String message, final Throwable cause, ExceptionContext context) {
super(message, cause);
if (context == null) {
context = new DefaultExceptionContext();
@@ -165,7 +165,7 @@ public class ContextedException extends
* @return {@code this}, for method chaining, not {@code null}
*/
@Override
- public ContextedException addContextValue(String label, Object value) {
+ public ContextedException addContextValue(final String label, final Object value) {
exceptionContext.addContextValue(label, value);
return this;
}
@@ -184,7 +184,7 @@ public class ContextedException extends
* @return {@code this}, for method chaining, not {@code null}
*/
@Override
- public ContextedException setContextValue(String label, Object value) {
+ public ContextedException setContextValue(final String label, final Object value) {
exceptionContext.setContextValue(label, value);
return this;
}
@@ -193,7 +193,7 @@ public class ContextedException extends
* {@inheritDoc}
*/
@Override
- public List<Object> getContextValues(String label) {
+ public List<Object> getContextValues(final String label) {
return this.exceptionContext.getContextValues(label);
}
@@ -201,7 +201,7 @@ public class ContextedException extends
* {@inheritDoc}
*/
@Override
- public Object getFirstContextValue(String label) {
+ public Object getFirstContextValue(final String label) {
return this.exceptionContext.getFirstContextValue(label);
}
@@ -247,7 +247,7 @@ public class ContextedException extends
* {@inheritDoc}
*/
@Override
- public String getFormattedExceptionMessage(String baseMessage) {
+ public String getFormattedExceptionMessage(final String baseMessage) {
return exceptionContext.getFormattedExceptionMessage(baseMessage);
}
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedRuntimeException.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedRuntimeException.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedRuntimeException.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ContextedRuntimeException.java Tue Jan 22 07:07:42 2013
@@ -105,7 +105,7 @@ public class ContextedRuntimeException e
*
* @param message the exception message, may be null
*/
- public ContextedRuntimeException(String message) {
+ public ContextedRuntimeException(final String message) {
super(message);
exceptionContext = new DefaultExceptionContext();
}
@@ -117,7 +117,7 @@ public class ContextedRuntimeException e
*
* @param cause the underlying cause of the exception, may be null
*/
- public ContextedRuntimeException(Throwable cause) {
+ public ContextedRuntimeException(final Throwable cause) {
super(cause);
exceptionContext = new DefaultExceptionContext();
}
@@ -130,7 +130,7 @@ public class ContextedRuntimeException e
* @param message the exception message, may be null
* @param cause the underlying cause of the exception, may be null
*/
- public ContextedRuntimeException(String message, Throwable cause) {
+ public ContextedRuntimeException(final String message, final Throwable cause) {
super(message, cause);
exceptionContext = new DefaultExceptionContext();
}
@@ -142,7 +142,7 @@ public class ContextedRuntimeException e
* @param cause the underlying cause of the exception, may be null
* @param context the context used to store the additional information, null uses default implementation
*/
- public ContextedRuntimeException(String message, Throwable cause, ExceptionContext context) {
+ public ContextedRuntimeException(final String message, final Throwable cause, ExceptionContext context) {
super(message, cause);
if (context == null) {
context = new DefaultExceptionContext();
@@ -165,7 +165,7 @@ public class ContextedRuntimeException e
* @return {@code this}, for method chaining, not {@code null}
*/
@Override
- public ContextedRuntimeException addContextValue(String label, Object value) {
+ public ContextedRuntimeException addContextValue(final String label, final Object value) {
exceptionContext.addContextValue(label, value);
return this;
}
@@ -184,7 +184,7 @@ public class ContextedRuntimeException e
* @return {@code this}, for method chaining, not {@code null}
*/
@Override
- public ContextedRuntimeException setContextValue(String label, Object value) {
+ public ContextedRuntimeException setContextValue(final String label, final Object value) {
exceptionContext.setContextValue(label, value);
return this;
}
@@ -193,7 +193,7 @@ public class ContextedRuntimeException e
* {@inheritDoc}
*/
@Override
- public List<Object> getContextValues(String label) {
+ public List<Object> getContextValues(final String label) {
return this.exceptionContext.getContextValues(label);
}
@@ -201,7 +201,7 @@ public class ContextedRuntimeException e
* {@inheritDoc}
*/
@Override
- public Object getFirstContextValue(String label) {
+ public Object getFirstContextValue(final String label) {
return this.exceptionContext.getFirstContextValue(label);
}
@@ -247,7 +247,7 @@ public class ContextedRuntimeException e
* {@inheritDoc}
*/
@Override
- public String getFormattedExceptionMessage(String baseMessage) {
+ public String getFormattedExceptionMessage(final String baseMessage) {
return exceptionContext.getFormattedExceptionMessage(baseMessage);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java Tue Jan 22 07:07:42 2013
@@ -50,7 +50,7 @@ public class DefaultExceptionContext imp
* {@inheritDoc}
*/
@Override
- public DefaultExceptionContext addContextValue(String label, Object value) {
+ public DefaultExceptionContext addContextValue(final String label, final Object value) {
contextValues.add(new ImmutablePair<String, Object>(label, value));
return this;
}
@@ -59,7 +59,7 @@ public class DefaultExceptionContext imp
* {@inheritDoc}
*/
@Override
- public DefaultExceptionContext setContextValue(String label, Object value) {
+ public DefaultExceptionContext setContextValue(final String label, final Object value) {
for (final Iterator<Pair<String, Object>> iter = contextValues.iterator(); iter.hasNext();) {
final Pair<String, Object> p = iter.next();
if (StringUtils.equals(label, p.getKey())) {
@@ -74,7 +74,7 @@ public class DefaultExceptionContext imp
* {@inheritDoc}
*/
@Override
- public List<Object> getContextValues(String label) {
+ public List<Object> getContextValues(final String label) {
final List<Object> values = new ArrayList<Object>();
for (final Pair<String, Object> pair : contextValues) {
if (StringUtils.equals(label, pair.getKey())) {
@@ -88,7 +88,7 @@ public class DefaultExceptionContext imp
* {@inheritDoc}
*/
@Override
- public Object getFirstContextValue(String label) {
+ public Object getFirstContextValue(final String label) {
for (final Pair<String, Object> pair : contextValues) {
if (StringUtils.equals(label, pair.getKey())) {
return pair.getValue();
@@ -124,7 +124,7 @@ public class DefaultExceptionContext imp
* @return the exception message <b>with</b> context information appended, never null
*/
@Override
- public String getFormattedExceptionMessage(String baseMessage){
+ public String getFormattedExceptionMessage(final String baseMessage){
StringBuilder buffer = new StringBuilder(256);
if (baseMessage != null) {
buffer.append(baseMessage);
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java Tue Jan 22 07:07:42 2013
@@ -120,7 +120,7 @@ public class ExceptionUtils {
* @deprecated This feature will be removed in Lang 4.0
*/
@Deprecated
- public static Throwable getCause(Throwable throwable) {
+ public static Throwable getCause(final Throwable throwable) {
return getCause(throwable, CAUSE_METHOD_NAMES);
}
@@ -138,7 +138,7 @@ public class ExceptionUtils {
* @deprecated This feature will be removed in Lang 4.0
*/
@Deprecated
- public static Throwable getCause(Throwable throwable, String[] methodNames) {
+ public static Throwable getCause(final Throwable throwable, String[] methodNames) {
if (throwable == null) {
return null;
}
@@ -176,7 +176,7 @@ public class ExceptionUtils {
* @return the root cause of the <code>Throwable</code>,
* <code>null</code> if none found or null throwable input
*/
- public static Throwable getRootCause(Throwable throwable) {
+ public static Throwable getRootCause(final Throwable throwable) {
List<Throwable> list = getThrowableList(throwable);
return list.size() < 2 ? null : (Throwable)list.get(list.size() - 1);
}
@@ -189,7 +189,7 @@ public class ExceptionUtils {
* @return the wrapped exception, or <code>null</code> if not found
*/
// TODO: Remove in Lang 4.0
- private static Throwable getCauseUsingMethodName(Throwable throwable, String methodName) {
+ private static Throwable getCauseUsingMethodName(final Throwable throwable, final String methodName) {
Method method = null;
try {
method = throwable.getClass().getMethod(methodName);
@@ -230,7 +230,7 @@ public class ExceptionUtils {
* @param throwable the throwable to inspect, may be null
* @return the count of throwables, zero if null input
*/
- public static int getThrowableCount(Throwable throwable) {
+ public static int getThrowableCount(final Throwable throwable) {
return getThrowableList(throwable).size();
}
@@ -253,7 +253,7 @@ public class ExceptionUtils {
* @param throwable the throwable to inspect, may be null
* @return the array of throwables, never null
*/
- public static Throwable[] getThrowables(Throwable throwable) {
+ public static Throwable[] getThrowables(final Throwable throwable) {
List<Throwable> list = getThrowableList(throwable);
return list.toArray(new Throwable[list.size()]);
}
@@ -301,7 +301,7 @@ public class ExceptionUtils {
* @param clazz the class to search for, subclasses do not match, null returns -1
* @return the index into the throwable chain, -1 if no match or null input
*/
- public static int indexOfThrowable(Throwable throwable, Class<?> clazz) {
+ public static int indexOfThrowable(final Throwable throwable, final Class<?> clazz) {
return indexOf(throwable, clazz, 0, false);
}
@@ -324,7 +324,7 @@ public class ExceptionUtils {
* negative treated as zero, larger than chain size returns -1
* @return the index into the throwable chain, -1 if no match or null input
*/
- public static int indexOfThrowable(Throwable throwable, Class<?> clazz, int fromIndex) {
+ public static int indexOfThrowable(final Throwable throwable, final Class<?> clazz, final int fromIndex) {
return indexOf(throwable, clazz, fromIndex, false);
}
@@ -344,7 +344,7 @@ public class ExceptionUtils {
* @return the index into the throwable chain, -1 if no match or null input
* @since 2.1
*/
- public static int indexOfType(Throwable throwable, Class<?> type) {
+ public static int indexOfType(final Throwable throwable, final Class<?> type) {
return indexOf(throwable, type, 0, true);
}
@@ -368,7 +368,7 @@ public class ExceptionUtils {
* @return the index into the throwable chain, -1 if no match or null input
* @since 2.1
*/
- public static int indexOfType(Throwable throwable, Class<?> type, int fromIndex) {
+ public static int indexOfType(final Throwable throwable, final Class<?> type, final int fromIndex) {
return indexOf(throwable, type, fromIndex, true);
}
@@ -383,7 +383,7 @@ public class ExceptionUtils {
* using references
* @return index of the <code>type</code> within throwables nested within the specified <code>throwable</code>
*/
- private static int indexOf(Throwable throwable, Class<?> type, int fromIndex, boolean subclass) {
+ private static int indexOf(final Throwable throwable, final Class<?> type, int fromIndex, final boolean subclass) {
if (throwable == null || type == null) {
return -1;
}
@@ -429,7 +429,7 @@ public class ExceptionUtils {
* @param throwable the throwable to output
* @since 2.0
*/
- public static void printRootCauseStackTrace(Throwable throwable) {
+ public static void printRootCauseStackTrace(final Throwable throwable) {
printRootCauseStackTrace(throwable, System.err);
}
@@ -452,7 +452,7 @@ public class ExceptionUtils {
* @throws IllegalArgumentException if the stream is <code>null</code>
* @since 2.0
*/
- public static void printRootCauseStackTrace(Throwable throwable, PrintStream stream) {
+ public static void printRootCauseStackTrace(final Throwable throwable, final PrintStream stream) {
if (throwable == null) {
return;
}
@@ -485,7 +485,7 @@ public class ExceptionUtils {
* @throws IllegalArgumentException if the writer is <code>null</code>
* @since 2.0
*/
- public static void printRootCauseStackTrace(Throwable throwable, PrintWriter writer) {
+ public static void printRootCauseStackTrace(final Throwable throwable, final PrintWriter writer) {
if (throwable == null) {
return;
}
@@ -513,7 +513,7 @@ public class ExceptionUtils {
* @return an array of stack trace frames, never null
* @since 2.0
*/
- public static String[] getRootCauseStackTrace(Throwable throwable) {
+ public static String[] getRootCauseStackTrace(final Throwable throwable) {
if (throwable == null) {
return ArrayUtils.EMPTY_STRING_ARRAY;
}
@@ -547,7 +547,7 @@ public class ExceptionUtils {
* @throws IllegalArgumentException if either argument is null
* @since 2.0
*/
- public static void removeCommonFrames(List<String> causeFrames, List<String> wrapperFrames) {
+ public static void removeCommonFrames(final List<String> causeFrames, final List<String> wrapperFrames) {
if (causeFrames == null || wrapperFrames == null) {
throw new IllegalArgumentException("The List must not be null");
}
@@ -579,7 +579,7 @@ public class ExceptionUtils {
* @return the stack trace as generated by the exception's
* <code>printStackTrace(PrintWriter)</code> method
*/
- public static String getStackTrace(Throwable throwable) {
+ public static String getStackTrace(final Throwable throwable) {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw, true);
throwable.printStackTrace(pw);
@@ -599,7 +599,7 @@ public class ExceptionUtils {
* @param throwable the <code>Throwable</code> to examine, may be null
* @return an array of strings describing each stack frame, never null
*/
- public static String[] getStackFrames(Throwable throwable) {
+ public static String[] getStackFrames(final Throwable throwable) {
if (throwable == null) {
return ArrayUtils.EMPTY_STRING_ARRAY;
}
@@ -615,7 +615,7 @@ public class ExceptionUtils {
* @param stackTrace a stack trace String
* @return an array where each element is a line from the argument
*/
- static String[] getStackFrames(String stackTrace) {
+ static String[] getStackFrames(final String stackTrace) {
String linebreak = SystemUtils.LINE_SEPARATOR;
StringTokenizer frames = new StringTokenizer(stackTrace, linebreak);
List<String> list = new ArrayList<String>();
@@ -637,7 +637,7 @@ public class ExceptionUtils {
* @param t is any throwable
* @return List of stack frames
*/
- static List<String> getStackFrameList(Throwable t) {
+ static List<String> getStackFrameList(final Throwable t) {
String stackTrace = getStackTrace(t);
String linebreak = SystemUtils.LINE_SEPARATOR;
StringTokenizer frames = new StringTokenizer(stackTrace, linebreak);
@@ -668,7 +668,7 @@ public class ExceptionUtils {
* @return the message, non-null
* @since Commons Lang 2.2
*/
- public static String getMessage(Throwable th) {
+ public static String getMessage(final Throwable th) {
if (th == null) {
return "";
}
@@ -688,7 +688,7 @@ public class ExceptionUtils {
* @return the message, non-null
* @since Commons Lang 2.2
*/
- public static String getRootCauseMessage(Throwable th) {
+ public static String getRootCauseMessage(final Throwable th) {
Throwable root = ExceptionUtils.getRootCause(th);
root = root == null ? th : root;
return getMessage(root);
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/Fraction.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/Fraction.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/Fraction.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/Fraction.java Tue Jan 22 07:07:42 2013
@@ -120,7 +120,7 @@ public final class Fraction extends Numb
* @param numerator the numerator, for example the three in 'three sevenths'
* @param denominator the denominator, for example the seven in 'three sevenths'
*/
- private Fraction(int numerator, int denominator) {
+ private Fraction(final int numerator, final int denominator) {
super();
this.numerator = numerator;
this.denominator = denominator;
@@ -169,7 +169,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator exceeds
* <code>Integer.MAX_VALUE</code>
*/
- public static Fraction getFraction(int whole, int numerator, int denominator) {
+ public static Fraction getFraction(final int whole, final int numerator, final int denominator) {
if (denominator == 0) {
throw new ArithmeticException("The denominator must not be zero");
}
@@ -543,7 +543,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator exceeds
* <code>Integer.MAX_VALUE</code>
*/
- public Fraction pow(int power) {
+ public Fraction pow(final int power) {
if (power == 1) {
return this;
} else if (power == 0) {
@@ -636,7 +636,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the result can not be represented as
* an int
*/
- private static int mulAndCheck(int x, int y) {
+ private static int mulAndCheck(final int x, final int y) {
long m = (long)x*(long)y;
if (m < Integer.MIN_VALUE ||
m > Integer.MAX_VALUE) {
@@ -654,7 +654,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the result can not be represented as
* an int
*/
- private static int mulPosAndCheck(int x, int y) {
+ private static int mulPosAndCheck(final int x, final int y) {
/* assert x>=0 && y>=0; */
long m = (long)x*(long)y;
if (m > Integer.MAX_VALUE) {
@@ -672,7 +672,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the result can not be represented as
* an int
*/
- private static int addAndCheck(int x, int y) {
+ private static int addAndCheck(final int x, final int y) {
long s = (long)x+(long)y;
if (s < Integer.MIN_VALUE ||
s > Integer.MAX_VALUE) {
@@ -690,7 +690,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the result can not be represented as
* an int
*/
- private static int subAndCheck(int x, int y) {
+ private static int subAndCheck(final int x, final int y) {
long s = (long)x-(long)y;
if (s < Integer.MIN_VALUE ||
s > Integer.MAX_VALUE) {
@@ -709,7 +709,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator exceeds
* <code>Integer.MAX_VALUE</code>
*/
- public Fraction add(Fraction fraction) {
+ public Fraction add(final Fraction fraction) {
return addSub(fraction, true /* add */);
}
@@ -723,7 +723,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator
* cannot be represented in an <code>int</code>.
*/
- public Fraction subtract(Fraction fraction) {
+ public Fraction subtract(final Fraction fraction) {
return addSub(fraction, false /* subtract */);
}
@@ -737,7 +737,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator
* cannot be represented in an <code>int</code>.
*/
- private Fraction addSub(Fraction fraction, boolean isAdd) {
+ private Fraction addSub(final Fraction fraction, final boolean isAdd) {
if (fraction == null) {
throw new IllegalArgumentException("The fraction must not be null");
}
@@ -793,7 +793,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator exceeds
* <code>Integer.MAX_VALUE</code>
*/
- public Fraction multiplyBy(Fraction fraction) {
+ public Fraction multiplyBy(final Fraction fraction) {
if (fraction == null) {
throw new IllegalArgumentException("The fraction must not be null");
}
@@ -819,7 +819,7 @@ public final class Fraction extends Numb
* @throws ArithmeticException if the resulting numerator or denominator exceeds
* <code>Integer.MAX_VALUE</code>
*/
- public Fraction divideBy(Fraction fraction) {
+ public Fraction divideBy(final Fraction fraction) {
if (fraction == null) {
throw new IllegalArgumentException("The fraction must not be null");
}
@@ -841,7 +841,7 @@ public final class Fraction extends Numb
* @return <code>true</code> if this object is equal
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj == this) {
return true;
}
@@ -880,7 +880,7 @@ public final class Fraction extends Numb
* @throws NullPointerException if the object is <code>null</code>
*/
@Override
- public int compareTo(Fraction other) {
+ public int compareTo(final Fraction other) {
if (this==other) {
return 0;
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/IEEE754rUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/IEEE754rUtils.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/IEEE754rUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/IEEE754rUtils.java Tue Jan 22 07:07:42 2013
@@ -34,7 +34,7 @@ public class IEEE754rUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static double min(double[] array) {
+ public static double min(final double[] array) {
// Validates input
if (array == null) {
throw new IllegalArgumentException("The Array must not be null");
@@ -59,7 +59,7 @@ public class IEEE754rUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static float min(float[] array) {
+ public static float min(final float[] array) {
// Validates input
if (array == null) {
throw new IllegalArgumentException("The Array must not be null");
@@ -86,7 +86,7 @@ public class IEEE754rUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static double min(double a, double b, double c) {
+ public static double min(final double a, final double b, final double c) {
return min(min(a, b), c);
}
@@ -99,7 +99,7 @@ public class IEEE754rUtils {
* @param b value 2
* @return the smallest of the values
*/
- public static double min(double a, double b) {
+ public static double min(final double a, final double b) {
if(Double.isNaN(a)) {
return b;
} else
@@ -120,7 +120,7 @@ public class IEEE754rUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static float min(float a, float b, float c) {
+ public static float min(final float a, final float b, final float c) {
return min(min(a, b), c);
}
@@ -133,7 +133,7 @@ public class IEEE754rUtils {
* @param b value 2
* @return the smallest of the values
*/
- public static float min(float a, float b) {
+ public static float min(final float a, final float b) {
if(Float.isNaN(a)) {
return b;
} else
@@ -152,7 +152,7 @@ public class IEEE754rUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static double max(double[] array) {
+ public static double max(final double[] array) {
// Validates input
if (array== null) {
throw new IllegalArgumentException("The Array must not be null");
@@ -177,7 +177,7 @@ public class IEEE754rUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static float max(float[] array) {
+ public static float max(final float[] array) {
// Validates input
if (array == null) {
throw new IllegalArgumentException("The Array must not be null");
@@ -204,7 +204,7 @@ public class IEEE754rUtils {
* @param c value 3
* @return the largest of the values
*/
- public static double max(double a, double b, double c) {
+ public static double max(final double a, final double b, final double c) {
return max(max(a, b), c);
}
@@ -217,7 +217,7 @@ public class IEEE754rUtils {
* @param b value 2
* @return the largest of the values
*/
- public static double max(double a, double b) {
+ public static double max(final double a, final double b) {
if(Double.isNaN(a)) {
return b;
} else
@@ -238,7 +238,7 @@ public class IEEE754rUtils {
* @param c value 3
* @return the largest of the values
*/
- public static float max(float a, float b, float c) {
+ public static float max(final float a, final float b, final float c) {
return max(max(a, b), c);
}
@@ -251,7 +251,7 @@ public class IEEE754rUtils {
* @param b value 2
* @return the largest of the values
*/
- public static float max(float a, float b) {
+ public static float max(final float a, final float b) {
if(Float.isNaN(a)) {
return b;
} else
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java Tue Jan 22 07:07:42 2013
@@ -96,7 +96,7 @@ public class NumberUtils {
* conversion fails
* @since 2.1
*/
- public static int toInt(String str) {
+ public static int toInt(final String str) {
return toInt(str, 0);
}
@@ -117,7 +117,7 @@ public class NumberUtils {
* @return the int represented by the string, or the default if conversion fails
* @since 2.1
*/
- public static int toInt(String str, int defaultValue) {
+ public static int toInt(final String str, final int defaultValue) {
if(str == null) {
return defaultValue;
}
@@ -145,7 +145,7 @@ public class NumberUtils {
* conversion fails
* @since 2.1
*/
- public static long toLong(String str) {
+ public static long toLong(final String str) {
return toLong(str, 0L);
}
@@ -166,7 +166,7 @@ public class NumberUtils {
* @return the long represented by the string, or the default if conversion fails
* @since 2.1
*/
- public static long toLong(String str, long defaultValue) {
+ public static long toLong(final String str, final long defaultValue) {
if (str == null) {
return defaultValue;
}
@@ -195,7 +195,7 @@ public class NumberUtils {
* if conversion fails
* @since 2.1
*/
- public static float toFloat(String str) {
+ public static float toFloat(final String str) {
return toFloat(str, 0.0f);
}
@@ -218,7 +218,7 @@ public class NumberUtils {
* if conversion fails
* @since 2.1
*/
- public static float toFloat(String str, float defaultValue) {
+ public static float toFloat(final String str, final float defaultValue) {
if (str == null) {
return defaultValue;
}
@@ -247,7 +247,7 @@ public class NumberUtils {
* if conversion fails
* @since 2.1
*/
- public static double toDouble(String str) {
+ public static double toDouble(final String str) {
return toDouble(str, 0.0d);
}
@@ -270,7 +270,7 @@ public class NumberUtils {
* if conversion fails
* @since 2.1
*/
- public static double toDouble(String str, double defaultValue) {
+ public static double toDouble(final String str, final double defaultValue) {
if (str == null) {
return defaultValue;
}
@@ -299,7 +299,7 @@ public class NumberUtils {
* conversion fails
* @since 2.5
*/
- public static byte toByte(String str) {
+ public static byte toByte(final String str) {
return toByte(str, (byte) 0);
}
@@ -320,7 +320,7 @@ public class NumberUtils {
* @return the byte represented by the string, or the default if conversion fails
* @since 2.5
*/
- public static byte toByte(String str, byte defaultValue) {
+ public static byte toByte(final String str, final byte defaultValue) {
if(str == null) {
return defaultValue;
}
@@ -348,7 +348,7 @@ public class NumberUtils {
* conversion fails
* @since 2.5
*/
- public static short toShort(String str) {
+ public static short toShort(final String str) {
return toShort(str, (short) 0);
}
@@ -369,7 +369,7 @@ public class NumberUtils {
* @return the short represented by the string, or the default if conversion fails
* @since 2.5
*/
- public static short toShort(String str, short defaultValue) {
+ public static short toShort(final String str, final short defaultValue) {
if(str == null) {
return defaultValue;
}
@@ -443,7 +443,7 @@ public class NumberUtils {
* @return Number created from the string (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static Number createNumber(String str) throws NumberFormatException {
+ public static Number createNumber(final String str) throws NumberFormatException {
if (str == null) {
return null;
}
@@ -612,7 +612,7 @@ public class NumberUtils {
* @param str the String to check
* @return if it is all zeros or <code>null</code>
*/
- private static boolean isAllZeros(String str) {
+ private static boolean isAllZeros(final String str) {
if (str == null) {
return true;
}
@@ -634,7 +634,7 @@ public class NumberUtils {
* @return converted <code>Float</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static Float createFloat(String str) {
+ public static Float createFloat(final String str) {
if (str == null) {
return null;
}
@@ -650,7 +650,7 @@ public class NumberUtils {
* @return converted <code>Double</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static Double createDouble(String str) {
+ public static Double createDouble(final String str) {
if (str == null) {
return null;
}
@@ -667,7 +667,7 @@ public class NumberUtils {
* @return converted <code>Integer</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static Integer createInteger(String str) {
+ public static Integer createInteger(final String str) {
if (str == null) {
return null;
}
@@ -685,7 +685,7 @@ public class NumberUtils {
* @return converted <code>Long</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static Long createLong(String str) {
+ public static Long createLong(final String str) {
if (str == null) {
return null;
}
@@ -702,7 +702,7 @@ public class NumberUtils {
* @return converted <code>BigInteger</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static BigInteger createBigInteger(String str) {
+ public static BigInteger createBigInteger(final String str) {
if (str == null) {
return null;
}
@@ -737,7 +737,7 @@ public class NumberUtils {
* @return converted <code>BigDecimal</code> (or null if the input is null)
* @throws NumberFormatException if the value cannot be converted
*/
- public static BigDecimal createBigDecimal(String str) {
+ public static BigDecimal createBigDecimal(final String str) {
if (str == null) {
return null;
}
@@ -765,7 +765,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static long min(long[] array) {
+ public static long min(final long[] array) {
// Validates input
validateArray(array);
@@ -788,7 +788,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static int min(int[] array) {
+ public static int min(final int[] array) {
// Validates input
validateArray(array);
@@ -811,7 +811,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static short min(short[] array) {
+ public static short min(final short[] array) {
// Validates input
validateArray(array);
@@ -834,7 +834,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static byte min(byte[] array) {
+ public static byte min(final byte[] array) {
// Validates input
validateArray(array);
@@ -858,7 +858,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is empty
* @see IEEE754rUtils#min(double[]) IEEE754rUtils for a version of this method that handles NaN differently
*/
- public static double min(double[] array) {
+ public static double min(final double[] array) {
// Validates input
validateArray(array);
@@ -885,7 +885,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is empty
* @see IEEE754rUtils#min(float[]) IEEE754rUtils for a version of this method that handles NaN differently
*/
- public static float min(float[] array) {
+ public static float min(final float[] array) {
// Validates input
validateArray(array);
@@ -913,7 +913,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static long max(long[] array) {
+ public static long max(final long[] array) {
// Validates input
validateArray(array);
@@ -936,7 +936,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static int max(int[] array) {
+ public static int max(final int[] array) {
// Validates input
validateArray(array);
@@ -959,7 +959,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static short max(short[] array) {
+ public static short max(final short[] array) {
// Validates input
validateArray(array);
@@ -982,7 +982,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is <code>null</code>
* @throws IllegalArgumentException if <code>array</code> is empty
*/
- public static byte max(byte[] array) {
+ public static byte max(final byte[] array) {
// Validates input
validateArray(array);
@@ -1006,7 +1006,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is empty
* @see IEEE754rUtils#max(double[]) IEEE754rUtils for a version of this method that handles NaN differently
*/
- public static double max(double[] array) {
+ public static double max(final double[] array) {
// Validates input
validateArray(array);
@@ -1033,7 +1033,7 @@ public class NumberUtils {
* @throws IllegalArgumentException if <code>array</code> is empty
* @see IEEE754rUtils#max(float[]) IEEE754rUtils for a version of this method that handles NaN differently
*/
- public static float max(float[] array) {
+ public static float max(final float[] array) {
// Validates input
validateArray(array);
@@ -1051,7 +1051,7 @@ public class NumberUtils {
return max;
}
- private static void validateArray(Object array) {
+ private static void validateArray(final Object array) {
if (array == null) {
throw new IllegalArgumentException("The Array must not be null");
} else if (Array.getLength(array) == 0) {
@@ -1069,7 +1069,7 @@ public class NumberUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static long min(long a, long b, long c) {
+ public static long min(long a, final long b, final long c) {
if (b < a) {
a = b;
}
@@ -1087,7 +1087,7 @@ public class NumberUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static int min(int a, int b, int c) {
+ public static int min(int a, final int b, final int c) {
if (b < a) {
a = b;
}
@@ -1105,7 +1105,7 @@ public class NumberUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static short min(short a, short b, short c) {
+ public static short min(short a, final short b, final short c) {
if (b < a) {
a = b;
}
@@ -1123,7 +1123,7 @@ public class NumberUtils {
* @param c value 3
* @return the smallest of the values
*/
- public static byte min(byte a, byte b, byte c) {
+ public static byte min(byte a, final byte b, final byte c) {
if (b < a) {
a = b;
}
@@ -1145,7 +1145,7 @@ public class NumberUtils {
* @return the smallest of the values
* @see IEEE754rUtils#min(double, double, double) for a version of this method that handles NaN differently
*/
- public static double min(double a, double b, double c) {
+ public static double min(final double a, final double b, final double c) {
return Math.min(Math.min(a, b), c);
}
@@ -1161,7 +1161,7 @@ public class NumberUtils {
* @return the smallest of the values
* @see IEEE754rUtils#min(float, float, float) for a version of this method that handles NaN differently
*/
- public static float min(float a, float b, float c) {
+ public static float min(final float a, final float b, final float c) {
return Math.min(Math.min(a, b), c);
}
@@ -1175,7 +1175,7 @@ public class NumberUtils {
* @param c value 3
* @return the largest of the values
*/
- public static long max(long a, long b, long c) {
+ public static long max(long a, final long b, final long c) {
if (b > a) {
a = b;
}
@@ -1193,7 +1193,7 @@ public class NumberUtils {
* @param c value 3
* @return the largest of the values
*/
- public static int max(int a, int b, int c) {
+ public static int max(int a, final int b, final int c) {
if (b > a) {
a = b;
}
@@ -1211,7 +1211,7 @@ public class NumberUtils {
* @param c value 3
* @return the largest of the values
*/
- public static short max(short a, short b, short c) {
+ public static short max(short a, final short b, final short c) {
if (b > a) {
a = b;
}
@@ -1229,7 +1229,7 @@ public class NumberUtils {
* @param c value 3
* @return the largest of the values
*/
- public static byte max(byte a, byte b, byte c) {
+ public static byte max(byte a, final byte b, final byte c) {
if (b > a) {
a = b;
}
@@ -1251,7 +1251,7 @@ public class NumberUtils {
* @return the largest of the values
* @see IEEE754rUtils#max(double, double, double) for a version of this method that handles NaN differently
*/
- public static double max(double a, double b, double c) {
+ public static double max(final double a, final double b, final double c) {
return Math.max(Math.max(a, b), c);
}
@@ -1267,7 +1267,7 @@ public class NumberUtils {
* @return the largest of the values
* @see IEEE754rUtils#max(float, float, float) for a version of this method that handles NaN differently
*/
- public static float max(float a, float b, float c) {
+ public static float max(final float a, final float b, final float c) {
return Math.max(Math.max(a, b), c);
}
@@ -1282,7 +1282,7 @@ public class NumberUtils {
* @param str the <code>String</code> to check
* @return <code>true</code> if str contains only Unicode numeric
*/
- public static boolean isDigits(String str) {
+ public static boolean isDigits(final String str) {
if (StringUtils.isEmpty(str)) {
return false;
}
@@ -1307,7 +1307,7 @@ public class NumberUtils {
* @param str the <code>String</code> to check
* @return <code>true</code> if the string is a correctly formatted number
*/
- public static boolean isNumber(String str) {
+ public static boolean isNumber(final String str) {
if (StringUtils.isEmpty(str)) {
return false;
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableBoolean.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableBoolean.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableBoolean.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableBoolean.java Tue Jan 22 07:07:42 2013
@@ -52,7 +52,7 @@ public class MutableBoolean implements M
*
* @param value the initial value to store
*/
- public MutableBoolean(boolean value) {
+ public MutableBoolean(final boolean value) {
super();
this.value = value;
}
@@ -63,7 +63,7 @@ public class MutableBoolean implements M
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableBoolean(Boolean value) {
+ public MutableBoolean(final Boolean value) {
super();
this.value = value.booleanValue();
}
@@ -84,7 +84,7 @@ public class MutableBoolean implements M
*
* @param value the value to set
*/
- public void setValue(boolean value) {
+ public void setValue(final boolean value) {
this.value = value;
}
@@ -95,7 +95,7 @@ public class MutableBoolean implements M
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Boolean value) {
+ public void setValue(final Boolean value) {
this.value = value.booleanValue();
}
@@ -151,7 +151,7 @@ public class MutableBoolean implements M
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof MutableBoolean) {
return value == ((MutableBoolean) obj).booleanValue();
}
@@ -177,7 +177,7 @@ public class MutableBoolean implements M
* where false is less than true
*/
@Override
- public int compareTo(MutableBoolean other) {
+ public int compareTo(final MutableBoolean other) {
boolean anotherVal = other.value;
return value == anotherVal ? 0 : (value ? 1 : -1);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableByte.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableByte.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableByte.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableByte.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableByte extends Number
*
* @param value the initial value to store
*/
- public MutableByte(byte value) {
+ public MutableByte(final byte value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableByte extends Number
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableByte(Number value) {
+ public MutableByte(final Number value) {
super();
this.value = value.byteValue();
}
@@ -72,7 +72,7 @@ public class MutableByte extends Number
* @throws NumberFormatException if the string cannot be parsed into a byte
* @since 2.5
*/
- public MutableByte(String value) throws NumberFormatException {
+ public MutableByte(final String value) throws NumberFormatException {
super();
this.value = Byte.parseByte(value);
}
@@ -93,7 +93,7 @@ public class MutableByte extends Number
*
* @param value the value to set
*/
- public void setValue(byte value) {
+ public void setValue(final byte value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableByte extends Number
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.byteValue();
}
@@ -134,7 +134,7 @@ public class MutableByte extends Number
* @param operand the value to add, not null
* @since Commons Lang 2.2
*/
- public void add(byte operand) {
+ public void add(final byte operand) {
this.value += operand;
}
@@ -145,7 +145,7 @@ public class MutableByte extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.byteValue();
}
@@ -155,7 +155,7 @@ public class MutableByte extends Number
* @param operand the value to subtract, not null
* @since Commons Lang 2.2
*/
- public void subtract(byte operand) {
+ public void subtract(final byte operand) {
this.value -= operand;
}
@@ -166,7 +166,7 @@ public class MutableByte extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.byteValue();
}
@@ -242,7 +242,7 @@ public class MutableByte extends Number
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof MutableByte) {
return value == ((MutableByte) obj).byteValue();
}
@@ -267,7 +267,7 @@ public class MutableByte extends Number
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableByte other) {
+ public int compareTo(final MutableByte other) {
byte anotherVal = other.value;
return value < anotherVal ? -1 : (value == anotherVal ? 0 : 1);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableDouble.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableDouble.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableDouble.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableDouble.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableDouble extends Numbe
*
* @param value the initial value to store
*/
- public MutableDouble(double value) {
+ public MutableDouble(final double value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableDouble extends Numbe
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableDouble(Number value) {
+ public MutableDouble(final Number value) {
super();
this.value = value.doubleValue();
}
@@ -72,7 +72,7 @@ public class MutableDouble extends Numbe
* @throws NumberFormatException if the string cannot be parsed into a double
* @since 2.5
*/
- public MutableDouble(String value) throws NumberFormatException {
+ public MutableDouble(final String value) throws NumberFormatException {
super();
this.value = Double.parseDouble(value);
}
@@ -93,7 +93,7 @@ public class MutableDouble extends Numbe
*
* @param value the value to set
*/
- public void setValue(double value) {
+ public void setValue(final double value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableDouble extends Numbe
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.doubleValue();
}
@@ -153,7 +153,7 @@ public class MutableDouble extends Numbe
* @param operand the value to add
* @since Commons Lang 2.2
*/
- public void add(double operand) {
+ public void add(final double operand) {
this.value += operand;
}
@@ -164,7 +164,7 @@ public class MutableDouble extends Numbe
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.doubleValue();
}
@@ -174,7 +174,7 @@ public class MutableDouble extends Numbe
* @param operand the value to subtract, not null
* @since Commons Lang 2.2
*/
- public void subtract(double operand) {
+ public void subtract(final double operand) {
this.value -= operand;
}
@@ -185,7 +185,7 @@ public class MutableDouble extends Numbe
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.doubleValue();
}
@@ -272,7 +272,7 @@ public class MutableDouble extends Numbe
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
return obj instanceof MutableDouble
&& Double.doubleToLongBits(((MutableDouble) obj).value) == Double.doubleToLongBits(value);
}
@@ -296,7 +296,7 @@ public class MutableDouble extends Numbe
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableDouble other) {
+ public int compareTo(final MutableDouble other) {
double anotherVal = other.value;
return Double.compare(value, anotherVal);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableFloat.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableFloat.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableFloat.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableFloat.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableFloat extends Number
*
* @param value the initial value to store
*/
- public MutableFloat(float value) {
+ public MutableFloat(final float value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableFloat extends Number
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableFloat(Number value) {
+ public MutableFloat(final Number value) {
super();
this.value = value.floatValue();
}
@@ -72,7 +72,7 @@ public class MutableFloat extends Number
* @throws NumberFormatException if the string cannot be parsed into a float
* @since 2.5
*/
- public MutableFloat(String value) throws NumberFormatException {
+ public MutableFloat(final String value) throws NumberFormatException {
super();
this.value = Float.parseFloat(value);
}
@@ -93,7 +93,7 @@ public class MutableFloat extends Number
*
* @param value the value to set
*/
- public void setValue(float value) {
+ public void setValue(final float value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableFloat extends Number
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.floatValue();
}
@@ -153,7 +153,7 @@ public class MutableFloat extends Number
* @param operand the value to add, not null
* @since Commons Lang 2.2
*/
- public void add(float operand) {
+ public void add(final float operand) {
this.value += operand;
}
@@ -164,7 +164,7 @@ public class MutableFloat extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.floatValue();
}
@@ -174,7 +174,7 @@ public class MutableFloat extends Number
* @param operand the value to subtract
* @since Commons Lang 2.2
*/
- public void subtract(float operand) {
+ public void subtract(final float operand) {
this.value -= operand;
}
@@ -185,7 +185,7 @@ public class MutableFloat extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.floatValue();
}
@@ -274,7 +274,7 @@ public class MutableFloat extends Number
* @see java.lang.Float#floatToIntBits(float)
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
return obj instanceof MutableFloat
&& Float.floatToIntBits(((MutableFloat) obj).value) == Float.floatToIntBits(value);
}
@@ -297,7 +297,7 @@ public class MutableFloat extends Number
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableFloat other) {
+ public int compareTo(final MutableFloat other) {
float anotherVal = other.value;
return Float.compare(value, anotherVal);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableInt.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableInt.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableInt.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableInt.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableInt extends Number i
*
* @param value the initial value to store
*/
- public MutableInt(int value) {
+ public MutableInt(final int value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableInt extends Number i
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableInt(Number value) {
+ public MutableInt(final Number value) {
super();
this.value = value.intValue();
}
@@ -72,7 +72,7 @@ public class MutableInt extends Number i
* @throws NumberFormatException if the string cannot be parsed into an int
* @since 2.5
*/
- public MutableInt(String value) throws NumberFormatException {
+ public MutableInt(final String value) throws NumberFormatException {
super();
this.value = Integer.parseInt(value);
}
@@ -93,7 +93,7 @@ public class MutableInt extends Number i
*
* @param value the value to set
*/
- public void setValue(int value) {
+ public void setValue(final int value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableInt extends Number i
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.intValue();
}
@@ -134,7 +134,7 @@ public class MutableInt extends Number i
* @param operand the value to add, not null
* @since Commons Lang 2.2
*/
- public void add(int operand) {
+ public void add(final int operand) {
this.value += operand;
}
@@ -145,7 +145,7 @@ public class MutableInt extends Number i
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.intValue();
}
@@ -155,7 +155,7 @@ public class MutableInt extends Number i
* @param operand the value to subtract, not null
* @since Commons Lang 2.2
*/
- public void subtract(int operand) {
+ public void subtract(final int operand) {
this.value -= operand;
}
@@ -166,7 +166,7 @@ public class MutableInt extends Number i
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.intValue();
}
@@ -232,7 +232,7 @@ public class MutableInt extends Number i
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof MutableInt) {
return value == ((MutableInt) obj).intValue();
}
@@ -257,7 +257,7 @@ public class MutableInt extends Number i
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableInt other) {
+ public int compareTo(final MutableInt other) {
int anotherVal = other.value;
return value < anotherVal ? -1 : (value == anotherVal ? 0 : 1);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableLong.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableLong.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableLong.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableLong.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableLong extends Number
*
* @param value the initial value to store
*/
- public MutableLong(long value) {
+ public MutableLong(final long value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableLong extends Number
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableLong(Number value) {
+ public MutableLong(final Number value) {
super();
this.value = value.longValue();
}
@@ -72,7 +72,7 @@ public class MutableLong extends Number
* @throws NumberFormatException if the string cannot be parsed into a long
* @since 2.5
*/
- public MutableLong(String value) throws NumberFormatException {
+ public MutableLong(final String value) throws NumberFormatException {
super();
this.value = Long.parseLong(value);
}
@@ -93,7 +93,7 @@ public class MutableLong extends Number
*
* @param value the value to set
*/
- public void setValue(long value) {
+ public void setValue(final long value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableLong extends Number
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.longValue();
}
@@ -134,7 +134,7 @@ public class MutableLong extends Number
* @param operand the value to add, not null
* @since Commons Lang 2.2
*/
- public void add(long operand) {
+ public void add(final long operand) {
this.value += operand;
}
@@ -145,7 +145,7 @@ public class MutableLong extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.longValue();
}
@@ -155,7 +155,7 @@ public class MutableLong extends Number
* @param operand the value to subtract, not null
* @since Commons Lang 2.2
*/
- public void subtract(long operand) {
+ public void subtract(final long operand) {
this.value -= operand;
}
@@ -166,7 +166,7 @@ public class MutableLong extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.longValue();
}
@@ -232,7 +232,7 @@ public class MutableLong extends Number
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof MutableLong) {
return value == ((MutableLong) obj).longValue();
}
@@ -257,7 +257,7 @@ public class MutableLong extends Number
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableLong other) {
+ public int compareTo(final MutableLong other) {
long anotherVal = other.value;
return value < anotherVal ? -1 : (value == anotherVal ? 0 : 1);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableObject.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableObject.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableObject.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableObject.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableObject<T> implements
*
* @param value the initial value to store
*/
- public MutableObject(T value) {
+ public MutableObject(final T value) {
super();
this.value = value;
}
@@ -71,7 +71,7 @@ public class MutableObject<T> implements
* @param value the value to set
*/
@Override
- public void setValue(T value) {
+ public void setValue(final T value) {
this.value = value;
}
@@ -89,7 +89,7 @@ public class MutableObject<T> implements
* <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj == null) {
return false;
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableShort.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableShort.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableShort.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/mutable/MutableShort.java Tue Jan 22 07:07:42 2013
@@ -49,7 +49,7 @@ public class MutableShort extends Number
*
* @param value the initial value to store
*/
- public MutableShort(short value) {
+ public MutableShort(final short value) {
super();
this.value = value;
}
@@ -60,7 +60,7 @@ public class MutableShort extends Number
* @param value the initial value to store, not null
* @throws NullPointerException if the object is null
*/
- public MutableShort(Number value) {
+ public MutableShort(final Number value) {
super();
this.value = value.shortValue();
}
@@ -72,7 +72,7 @@ public class MutableShort extends Number
* @throws NumberFormatException if the string cannot be parsed into a short
* @since 2.5
*/
- public MutableShort(String value) throws NumberFormatException {
+ public MutableShort(final String value) throws NumberFormatException {
super();
this.value = Short.parseShort(value);
}
@@ -93,7 +93,7 @@ public class MutableShort extends Number
*
* @param value the value to set
*/
- public void setValue(short value) {
+ public void setValue(final short value) {
this.value = value;
}
@@ -104,7 +104,7 @@ public class MutableShort extends Number
* @throws NullPointerException if the object is null
*/
@Override
- public void setValue(Number value) {
+ public void setValue(final Number value) {
this.value = value.shortValue();
}
@@ -134,7 +134,7 @@ public class MutableShort extends Number
* @param operand the value to add, not null
* @since Commons Lang 2.2
*/
- public void add(short operand) {
+ public void add(final short operand) {
this.value += operand;
}
@@ -145,7 +145,7 @@ public class MutableShort extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void add(Number operand) {
+ public void add(final Number operand) {
this.value += operand.shortValue();
}
@@ -155,7 +155,7 @@ public class MutableShort extends Number
* @param operand the value to subtract, not null
* @since Commons Lang 2.2
*/
- public void subtract(short operand) {
+ public void subtract(final short operand) {
this.value -= operand;
}
@@ -166,7 +166,7 @@ public class MutableShort extends Number
* @throws NullPointerException if the object is null
* @since Commons Lang 2.2
*/
- public void subtract(Number operand) {
+ public void subtract(final Number operand) {
this.value -= operand.shortValue();
}
@@ -242,7 +242,7 @@ public class MutableShort extends Number
* @return <code>true</code> if the objects are the same; <code>false</code> otherwise.
*/
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof MutableShort) {
return value == ((MutableShort) obj).shortValue();
}
@@ -267,7 +267,7 @@ public class MutableShort extends Number
* @return negative if this is less, zero if equal, positive if greater
*/
@Override
- public int compareTo(MutableShort other) {
+ public int compareTo(final MutableShort other) {
short anotherVal = other.value;
return value < anotherVal ? -1 : (value == anotherVal ? 0 : 1);
}
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/reflect/ConstructorUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/reflect/ConstructorUtils.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/reflect/ConstructorUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/reflect/ConstructorUtils.java Tue Jan 22 07:07:42 2013
@@ -75,7 +75,7 @@ public class ConstructorUtils {
* @throws InstantiationException if an error occurs on instantiation
* @see #invokeConstructor(java.lang.Class, java.lang.Object[], java.lang.Class[])
*/
- public static <T> T invokeConstructor(Class<T> cls, Object... args)
+ public static <T> T invokeConstructor(final Class<T> cls, Object... args)
throws NoSuchMethodException, IllegalAccessException, InvocationTargetException,
InstantiationException {
if (args == null) {
@@ -104,7 +104,7 @@ public class ConstructorUtils {
* @throws InstantiationException if an error occurs on instantiation
* @see Constructor#newInstance
*/
- public static <T> T invokeConstructor(Class<T> cls, Object[] args, Class<?>[] parameterTypes)
+ public static <T> T invokeConstructor(final Class<T> cls, Object[] args, Class<?>[] parameterTypes)
throws NoSuchMethodException, IllegalAccessException, InvocationTargetException,
InstantiationException {
if (parameterTypes == null) {
@@ -139,7 +139,7 @@ public class ConstructorUtils {
* @throws InstantiationException if an error occurs on instantiation
* @see #invokeExactConstructor(java.lang.Class, java.lang.Object[], java.lang.Class[])
*/
- public static <T> T invokeExactConstructor(Class<T> cls, Object... args)
+ public static <T> T invokeExactConstructor(final Class<T> cls, Object... args)
throws NoSuchMethodException, IllegalAccessException, InvocationTargetException,
InstantiationException {
if (args == null) {
@@ -168,7 +168,7 @@ public class ConstructorUtils {
* @throws InstantiationException if an error occurs on instantiation
* @see Constructor#newInstance
*/
- public static <T> T invokeExactConstructor(Class<T> cls, Object[] args,
+ public static <T> T invokeExactConstructor(final Class<T> cls, Object[] args,
Class<?>[] parameterTypes) throws NoSuchMethodException, IllegalAccessException,
InvocationTargetException, InstantiationException {
if (args == null) {
@@ -199,8 +199,8 @@ public class ConstructorUtils {
* @see Class#getConstructor
* @see #getAccessibleConstructor(java.lang.reflect.Constructor)
*/
- public static <T> Constructor<T> getAccessibleConstructor(Class<T> cls,
- Class<?>... parameterTypes) {
+ public static <T> Constructor<T> getAccessibleConstructor(final Class<T> cls,
+ final Class<?>... parameterTypes) {
try {
return getAccessibleConstructor(cls.getConstructor(parameterTypes));
} catch (NoSuchMethodException e) {
@@ -218,7 +218,7 @@ public class ConstructorUtils {
* @return the constructor, null if no matching accessible constructor found
* @see java.lang.SecurityManager
*/
- public static <T> Constructor<T> getAccessibleConstructor(Constructor<T> ctor) {
+ public static <T> Constructor<T> getAccessibleConstructor(final Constructor<T> ctor) {
return MemberUtils.isAccessible(ctor)
&& Modifier.isPublic(ctor.getDeclaringClass().getModifiers()) ? ctor : null;
}
@@ -240,8 +240,8 @@ public class ConstructorUtils {
* @param parameterTypes find method with compatible parameters
* @return the constructor, null if no matching accessible constructor found
*/
- public static <T> Constructor<T> getMatchingAccessibleConstructor(Class<T> cls,
- Class<?>... parameterTypes) {
+ public static <T> Constructor<T> getMatchingAccessibleConstructor(final Class<T> cls,
+ final Class<?>... parameterTypes) {
// see if we can find the constructor directly
// most of the time this works and it's much faster
try {