You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/12 07:11:34 UTC

[GitHub] [flink] gaborgsomogyi opened a new pull request #16463: [FLINK-21108][web] Add custom netty HTTP request inbound/outbound handlers

gaborgsomogyi opened a new pull request #16463:
URL: https://github.com/apache/flink/pull/16463


   ## What is the purpose of the change
   
   At the moment there is no possibility to influence netty HTTP inbound/outbound requests. This could be useful from many perspectives. A good example (amongst others) is authentication/authorization. Here are the exact examples:
   * With an outbound custom netty handler one can modify the HTTP request by adding authentication information.
   * With an inbound custom netty handler one can do authentication/authorization.
   
   In this PR I've added 2 generic APIs in order to handle inbound and outbound HTTP requests.
   Please see [FLIP-181](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=184616200) for further details.
   
   ## Brief change log
   
   * Added. `InboundChannelHandlerFactory`
   * Added. `OutboundChannelHandlerFactory`
   * `TestRestServerEndpoint` and `RestClient` are now getting Flink `Configuration` instances.
   
   ## Verifying this change
   
   * Existing automated tests
   * There are 2 not yet published external repositories with automated tests using the newly added APIs:
     * Basic authentication
     * Kerberos authentication
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes, introduced 2 `@Experimental` APIs
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs + API usage examples (intended to be published when APIs are in place)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 758e058554d003959bb42ca3988a306389e1b9d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481) 
   * 2f1be8aeb879f80c87f19f1a6059459d8d04372e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-894061690






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669",
       "triggerID" : "894061763",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "894061763",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 06823a474b4bae30c90608a72bb72123b909f48b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b99a4a2bedce5cb69659c7235babdc127a580d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425) 
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-896013597


   @gyfora it would be nice to update the JIRA tickets when merging a PR. Otherwise it is hard to find the paper trail when looking things up. Concretely, this PR seems to reference FLINK-21108 as in the commit but the PR title states that it is FLINK-23272. Moreover, FLINK-21108 has been closed as a duplicate more than a month ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309) 
   * 758e058554d003959bb42ca3988a306389e1b9d3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-891672766


   As a start resolved the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-896032871


   Yea, we updated the ticket but unfortunately wrong ticket was referenced in the commit. We were so preoccupied with the CI problems that we did not notice this. :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b99a4a2bedce5cb69659c7235babdc127a580d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425) 
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481) 
   * 2f1be8aeb879f80c87f19f1a6059459d8d04372e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 758e058554d003959bb42ca3988a306389e1b9d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386) 
   * 53b99a4a2bedce5cb69659c7235babdc127a580d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-893234348






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
tillrohrmann edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-896013597


   @gyfora it would be nice to update the JIRA tickets when merging a PR. Otherwise it is hard to find the paper trail when looking things up. Concretely, this PR seems to reference FLINK-21108 in the commit but the PR title states that it is FLINK-23272. Moreover, FLINK-21108 has been closed as a duplicate more than a month ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-894196201


   `BlockingShuffleITCase` failed which is another flaky test. Filing jira-s to highlight the flakyness of these tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-893234348


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on a change in pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #16463:
URL: https://github.com/apache/flink/pull/16463#discussion_r682345714



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/InboundChannelHandlerFactory.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.ConfigurationException;
+
+import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandler;
+
+import java.util.Map;
+
+/**
+ * Custom netty inbound handler factory in order to make custom changes on netty inbound data. Good
+ * example usage of this API is custom authentication. When the user is not authenticated then the
+ * instantiated channel handler can send back 401 to trigger negotiation. Since implementations are
+ * loaded with service loader it's discouraged to store any internal state in factories.
+ */
+@Experimental
+public interface InboundChannelHandlerFactory {
+    /**
+     * Gives back priority of the {@link ChannelHandler}. The bigger the value is, the earlier it is
+     * executed. If multiple handlers have the same priority then the order is not defined.
+     *
+     * @return the priority of the {@link ChannelHandler}.
+     */
+    int priority();
+
+    /**
+     * Creates new instance of {@link ChannelHandler}
+     *
+     * @param configuration The Flink {@link Configuration}.
+     * @param responseHeaders The response headers.
+     * @return {@link ChannelHandler} or null if no custom handler need to be created.
+     * @throws ConfigurationException Thrown, if the handler configuration is incorrect.
+     */
+    ChannelHandler createHandler(Configuration configuration, Map<String, String> responseHeaders)

Review comment:
       Changed.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/OutboundChannelHandlerFactory.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.ConfigurationException;
+
+import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandler;
+
+/**
+ * Custom netty outbound handler factory in order to make custom changes on netty outbound data.
+ * Good example usage of this API is custom authentication. When the user wants to send
+ * authentication information then the instantiated channel handler can modify the HTTP request.
+ * Since implementations are loaded with service loader it's discouraged to store any internal state
+ * in factories.
+ */
+@Experimental
+public interface OutboundChannelHandlerFactory {
+    /**
+     * Gives back priority of the {@link ChannelHandler}. The bigger the value is, the earlier it is
+     * executed. If multiple handlers have the same priority then the order is not defined.
+     *
+     * @return the priority of the {@link ChannelHandler}.
+     */
+    int priority();
+
+    /**
+     * Creates new instance of {@link ChannelHandler}
+     *
+     * @param configuration The Flink {@link Configuration}.
+     * @return {@link ChannelHandler} or null if no custom handler needs to be created.
+     * @throws ConfigurationException Thrown, if the handler configuration is incorrect.
+     */
+    ChannelHandler createHandler(Configuration configuration) throws ConfigurationException;

Review comment:
       Changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-896063116


   Np. I think it should be fine if you update the respective Jira tickets accordingly. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-892628134


   @gyfora added proper tests which are testing the loaded factories behavior but this has increased the PR size significantly. I don't think I can come up w/ more simple tests. If somebody has any idea please share.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b5159766fdbab7f84ffb96a151cf9cbb659f71f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481) 
   * 2f1be8aeb879f80c87f19f1a6059459d8d04372e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524) 
   * 8743ec576ba567b1534455ca608ac0064a6e4834 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b99a4a2bedce5cb69659c7235babdc127a580d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   * 06823a474b4bae30c90608a72bb72123b909f48b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-894200362


   Filed FLINK-23665 and FLINK-23666.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora commented on a change in pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #16463:
URL: https://github.com/apache/flink/pull/16463#discussion_r674965460



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/InboundChannelHandlerFactory.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.ConfigurationException;
+
+import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandler;
+
+import java.util.Map;
+
+/**
+ * Custom netty inbound handler factory in order to make custom changes on netty inbound data. Good
+ * example usage of this API is custom authentication. When the user is not authenticated then the
+ * instantiated channel handler can send back 401 to trigger negotiation. Since implementations are
+ * loaded with service loader it's discouraged to store any internal state in factories.
+ */
+@Experimental
+public interface InboundChannelHandlerFactory {
+    /**
+     * Gives back priority of the {@link ChannelHandler}. The bigger the value is, the earlier it is
+     * executed. If multiple handlers have the same priority then the order is not defined.
+     *
+     * @return the priority of the {@link ChannelHandler}.
+     */
+    int priority();
+
+    /**
+     * Creates new instance of {@link ChannelHandler}
+     *
+     * @param configuration The Flink {@link Configuration}.
+     * @param responseHeaders The response headers.
+     * @return {@link ChannelHandler} or null if no custom handler need to be created.
+     * @throws ConfigurationException Thrown, if the handler configuration is incorrect.
+     */
+    ChannelHandler createHandler(Configuration configuration, Map<String, String> responseHeaders)

Review comment:
       I agree with @tillrohrmann, this should return Optional<ChannelHandler> to make the behaviour explicit

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/OutboundChannelHandlerFactory.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.ConfigurationException;
+
+import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandler;
+
+/**
+ * Custom netty outbound handler factory in order to make custom changes on netty outbound data.
+ * Good example usage of this API is custom authentication. When the user wants to send
+ * authentication information then the instantiated channel handler can modify the HTTP request.
+ * Since implementations are loaded with service loader it's discouraged to store any internal state
+ * in factories.
+ */
+@Experimental
+public interface OutboundChannelHandlerFactory {
+    /**
+     * Gives back priority of the {@link ChannelHandler}. The bigger the value is, the earlier it is
+     * executed. If multiple handlers have the same priority then the order is not defined.
+     *
+     * @return the priority of the {@link ChannelHandler}.
+     */
+    int priority();
+
+    /**
+     * Creates new instance of {@link ChannelHandler}
+     *
+     * @param configuration The Flink {@link Configuration}.
+     * @return {@link ChannelHandler} or null if no custom handler needs to be created.
+     * @throws ConfigurationException Thrown, if the handler configuration is incorrect.
+     */
+    ChannelHandler createHandler(Configuration configuration) throws ConfigurationException;

Review comment:
       I agree with @tillrohrmann, this should return Optional<ChannelHandler> to make the behaviour explicit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309) 
   * 758e058554d003959bb42ca3988a306389e1b9d3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-893236679


   @flinkbot approve all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16463: [FLINK-21108][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878032738


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 (Mon Jul 12 07:14:32 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21108).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06823a474b4bae30c90608a72bb72123b909f48b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   * 06823a474b4bae30c90608a72bb72123b909f48b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669",
       "triggerID" : "894061763",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 06823a474b4bae30c90608a72bb72123b909f48b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asfgit closed pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #16463:
URL: https://github.com/apache/flink/pull/16463


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2f1be8aeb879f80c87f19f1a6059459d8d04372e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524) 
   * 8743ec576ba567b1534455ca608ac0064a6e4834 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-892419691


   The tests are not yet testing the netty chain so discovering how is it possible to do that w/o horror complex code...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 743a2a820d59d3a76b8ebb6909309c45c14ae7f6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21481",
       "triggerID" : "8b5159766fdbab7f84ffb96a151cf9cbb659f71f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21524",
       "triggerID" : "2f1be8aeb879f80c87f19f1a6059459d8d04372e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21580",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8743ec576ba567b1534455ca608ac0064a6e4834",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21541",
       "triggerID" : "893234348",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669",
       "triggerID" : "894061763",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "06823a474b4bae30c90608a72bb72123b909f48b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619",
       "triggerID" : "894061763",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 06823a474b4bae30c90608a72bb72123b909f48b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21669) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-892628134


   @gyfora added proper tests which are testing the loaded factories behavior but this has increased the PR size significantly. I don't think I can come up w/ more simple tests. If somebody has any idea please share.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16463: [FLINK-23272][web] Add custom netty HTTP request inbound/outbound handlers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16463:
URL: https://github.com/apache/flink/pull/16463#issuecomment-878058026


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20309",
       "triggerID" : "743a2a820d59d3a76b8ebb6909309c45c14ae7f6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386",
       "triggerID" : "758e058554d003959bb42ca3988a306389e1b9d3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425",
       "triggerID" : "53b99a4a2bedce5cb69659c7235babdc127a580d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 758e058554d003959bb42ca3988a306389e1b9d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21386) 
   * 53b99a4a2bedce5cb69659c7235babdc127a580d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21425) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org