[apache/incubator-tvm] [Release] Add cma as a separate 3rdparty repo (#4434)

[Liangfu Chen <no...@github.com>]

Following #4431, this PR removes cma module completely and adds it as a separate 3rdparty repo.
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-tvm/pull/4434

-- Commit Summary --

  * remove cma directory

-- File Changes --

    D 3rdparty/cma/cma.h (46)
    D 3rdparty/cma/cma_api_impl.h (179)
    D 3rdparty/cma/settings.mk (19)

-- Patch Links --

https://github.com/apache/incubator-tvm/pull/4434.patch
https://github.com/apache/incubator-tvm/pull/4434.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Liangfu Chen <no...@github.com>]

@tmoreau89 Oh, I think we might need two steps for resolving the conflict (I might be wrong). First, to remove cma directory completely. Second, to add the submodule. Let this PR take the first change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#issuecomment-558959859

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Tianqi Chen <no...@github.com>]

Unfortunately we cannot add it as a submodule either. Let us separate the kernel module out into a repo with instructions, and point to the repo to build the kernel module. The driver part can remain in the repo

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#issuecomment-559178093

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Tianqi Chen <no...@github.com>]

NOTE, the only thing we need to be careful about is the linux kernel module cma.c, which declared the binary driver's license to be GPL. The previous action to remove them was mainly act caution.

Background: we tried to package all source code in the 3rdparty during a release, if a folder contains potential GPL code, we cannot bundle it during release.

We need to determine the license of that source code, given that it includes linux header, would that makes the source code GPL, or is it OK to mark as MIT and in MODULE_LICENSE mark the driver as dual MIT and GPL.  

If we decided that the code can be MIT, then we can include it as part of 3rdparty source. Otherwise, we need to cut the code from the source release. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#issuecomment-559196440

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Liangfu Chen <no...@github.com>]

Thanks for the explanation.
In this case, we shall only put application layer code into `3rdparty`, and only leave kernel module out of the repository. I would like to close this PR for now and put an update to fix the compilation error in a separate PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#issuecomment-559715028

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Thierry Moreau <no...@github.com>]

@liangfu there is a CI error related to the new submodule, can you take a look?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#issuecomment-558953029

Re: [apache/incubator-tvm] [Release] Add cma as a submodule (#4434)

[Liangfu Chen <no...@github.com>]

Closed #4434.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/4434#event-2840765879