[jira] [Commented] (CASSANDRA-7763) cql_tests static_with_empty_clustering test failure

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098406#comment-14098406 ] 

Benedict commented on CASSANDRA-7763:
-------------------------------------

It's a shame we've spot this now, as it's a bit late to optimise this again for 2.1, but we should perhaps revisit later (for 3.0), as the introduction of these virtual method invocations was a large part of the reason for CASSANDRA-6934 in the first place. It should be possible to avoid these invocations on most calls, since we only actually incur static columns infrequently, but let's leave it for now.

This patch does need to include the changes to the AbstractCType.compareUnsigned, WithCollection.compare() and AbstractNativeCell.compare() methods as well though



> cql_tests static_with_empty_clustering test failure
> ---------------------------------------------------
>
>                 Key: CASSANDRA-7763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7763
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Ryan McGuire
>            Assignee: Sylvain Lebresne
>             Fix For: 2.1 rc6
>
>         Attachments: 7763.txt
>
>
> {code}
> ======================================================================
> FAIL: static_with_empty_clustering_test (cql_tests.TestCQL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/ryan/git/datastax/cassandra-dtest/tools.py", line 213, in wrapped
>     f(obj)
>   File "/home/ryan/git/datastax/cassandra-dtest/cql_tests.py", line 4082, in static_with_empty_clustering_test
>     assert_one(cursor, "SELECT * FROM test", ['partition1', '', 'static value', 'value'])
>   File "/home/ryan/git/datastax/cassandra-dtest/assertions.py", line 40, in assert_one
>     assert res == [expected], res
> AssertionError: [[u'partition1', u'', None, None], [u'partition1', u'', None, None], [u'partition1', u'', None, u'value']]
> -------------------- >> begin captured logging << --------------------
> dtest: DEBUG: cluster ccm directory: /tmp/dtest-Ex54V7
> --------------------- >> end captured logging << ---------------------
> ----------------------------------------------------------------------
> Ran 1 test in 6.866s
> FAILED (failures=1)
> {code}
> regression from CASSANDRA-7455?



--
This message was sent by Atlassian JIRA
(v6.2#6252)