You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by pkuwm <gi...@git.apache.org> on 2016/05/03 21:18:04 UTC
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
GitHub user pkuwm opened a pull request:
https://github.com/apache/incubator-eagle/pull/173
EAGLE-287. Make EagleStore as the default notification method.
[master acf0d6c] EAGLE-287. Make EagleStore as the default notification method. Provide an optional configuration in application.conf file for disabling eagleStore as the default notification \u2013 "eagleStoreEnabled". If "eagleStoreEnabled = false", eaglestore is disabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pkuwm/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 0879936dea917bf33900eccd85c5f756bf133c92
Author: Lu <hn...@lm-sjc-11002130.corp.ebay.com>
Date: 2016-05-03T17:03:16Z
EAGLE-289. Change dataSource to application and delete duplicate email template.
commit d27d8e1d8e2b749910e49756e857667b4cbc3352
Author: pkuwm <pk...@users.noreply.github.com>
Date: 2016-05-03T18:03:06Z
Merge pull request #1 from apache/master
EAGLE-289 fix alert email format
commit acf0d6cdde09231563ccd1f86178d196e796d8e4
Author: Lu <hn...@lm-sjc-11002130.corp.ebay.com>
Date: 2016-05-03T19:15:09Z
EAGLE-287. Make EagleStore as the default notification method. Provide an optional configuration in application.conf file for disabling eagleStore as the default notification \u2013 "eagleStoreEnabled". If "eagleStoreEnabled = false", eaglestore is disabled.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/173#issuecomment-217118027
Basically, Adding notification plugin is a issue related to policy definition, but not to a specific topology.
I have another idea to handle this issue, but not adding a configuration value for a specific topology.
That is, let the front end provide a default notification plugin EagleStore when define a policy. How do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
Posted by pkuwm <gi...@git.apache.org>.
Github user pkuwm closed the pull request at:
https://github.com/apache/incubator-eagle/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
Posted by pkuwm <gi...@git.apache.org>.
Github user pkuwm closed the pull request at:
https://github.com/apache/incubator-eagle/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
Posted by pkuwm <gi...@git.apache.org>.
GitHub user pkuwm reopened a pull request:
https://github.com/apache/incubator-eagle/pull/173
EAGLE-287. Make EagleStore as the default notification method.
[master acf0d6c] EAGLE-287. Make EagleStore as the default notification method. Provide an optional configuration in application.conf file for disabling eagleStore as the default notification \u2013 "eagleStoreEnabled". If "eagleStoreEnabled = false", eaglestore is disabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pkuwm/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 0879936dea917bf33900eccd85c5f756bf133c92
Author: Lu <hn...@lm-sjc-11002130.corp.ebay.com>
Date: 2016-05-03T17:03:16Z
EAGLE-289. Change dataSource to application and delete duplicate email template.
commit d27d8e1d8e2b749910e49756e857667b4cbc3352
Author: pkuwm <pk...@users.noreply.github.com>
Date: 2016-05-03T18:03:06Z
Merge pull request #1 from apache/master
EAGLE-289 fix alert email format
commit acf0d6cdde09231563ccd1f86178d196e796d8e4
Author: Lu <hn...@lm-sjc-11002130.corp.ebay.com>
Date: 2016-05-03T19:15:09Z
EAGLE-287. Make EagleStore as the default notification method. Provide an optional configuration in application.conf file for disabling eagleStore as the default notification \u2013 "eagleStoreEnabled". If "eagleStoreEnabled = false", eaglestore is disabled.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-287. Make EagleStore as the de...
Posted by pkuwm <gi...@git.apache.org>.
Github user pkuwm commented on the pull request:
https://github.com/apache/incubator-eagle/pull/173#issuecomment-221385835
Close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---