You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/03 02:04:51 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8724: handle
nulls in bar chart series/breakdown
codecov-io commented on issue #8724: handle nulls in bar chart series/breakdown
URL: https://github.com/apache/incubator-superset/pull/8724#issuecomment-560964798
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=h1) Report
> Merging [#8724](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/871af05f681f1a9f3383beda1037dd5fa5905683?src=pr&el=desc) will **increase** coverage by `6.32%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8724 +/- ##
==========================================
+ Coverage 65.4% 71.73% +6.32%
==========================================
Files 482 123 -359
Lines 24083 12799 -11284
Branches 2763 0 -2763
==========================================
- Hits 15751 9181 -6570
+ Misses 8152 3618 -4534
+ Partials 180 0 -180
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.86% <100%> (+0.02%)` | :arrow_up: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.52% <100%> (+0.04%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.83% <100%> (+0.02%)` | :arrow_up: |
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100% <100%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.38% <100%> (+0.05%)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | | |
| ... and [359 more](https://codecov.io/gh/apache/incubator-superset/pull/8724/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=footer). Last update [871af05...8e40754](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org