You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/04 13:36:45 UTC
[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema
dajac commented on a change in pull request #9526:
URL: https://github.com/apache/kafka/pull/9526#discussion_r517317354
##########
File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala
##########
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.network
+
+import java.util
+
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, BinaryNode, DoubleNode, IntNode, JsonNodeFactory, LongNode, NullNode, ObjectNode, ShortNode, TextNode}
+import kafka.network.RequestChannel.{Response, Session}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.network.ClientInformation
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.record.RecordBatch
+import org.apache.kafka.common.requests._
+import org.apache.kafka.common.utils.CollectionUtils
+
+import scala.jdk.CollectionConverters._
+
+object RequestConvertToJson {
+ def request(request: AbstractRequest, verbose: Boolean): JsonNode = {
Review comment:
It seems that `verbose` is not used anymore. I think that we were dumping the full Produce request and Fetch response when `verbose` was `true`. Should we just remove it?
##########
File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala
##########
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.network
+
+import java.util
+
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, BinaryNode, DoubleNode, IntNode, JsonNodeFactory, LongNode, NullNode, ObjectNode, ShortNode, TextNode}
+import kafka.network.RequestChannel.{Response, Session}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.network.ClientInformation
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.record.RecordBatch
+import org.apache.kafka.common.requests._
+import org.apache.kafka.common.utils.CollectionUtils
+
+import scala.jdk.CollectionConverters._
+
+object RequestConvertToJson {
+ def request(request: AbstractRequest, verbose: Boolean): JsonNode = {
+ request match {
+ case req: AddOffsetsToTxnRequest => AddOffsetsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AddPartitionsToTxnRequest => AddPartitionsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterClientQuotasRequest => AlterClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterConfigsRequest => AlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterIsrRequest => AlterIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterPartitionReassignmentsRequest => AlterPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterReplicaLogDirsRequest => AlterReplicaLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case res: AlterUserScramCredentialsRequest => AlterUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ApiVersionsRequest => ApiVersionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: BeginQuorumEpochRequest => BeginQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ControlledShutdownRequest => ControlledShutdownRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateAclsRequest => CreateAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateDelegationTokenRequest => CreateDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreatePartitionsRequest => CreatePartitionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateTopicsRequest => CreateTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteAclsRequest => DeleteAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteGroupsRequest => DeleteGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteRecordsRequest => DeleteRecordsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteTopicsRequest => DeleteTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeAclsRequest => DescribeAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeClientQuotasRequest => DescribeClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeConfigsRequest => DescribeConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeDelegationTokenRequest => DescribeDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeGroupsRequest => DescribeGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeLogDirsRequest => DescribeLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeQuorumRequest => DescribeQuorumRequestDataJsonConverter.write(req.data, request.version)
+ case res: DescribeUserScramCredentialsRequest => DescribeUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ElectLeadersRequest => ElectLeadersRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndTxnRequest => EndTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndQuorumEpochRequest => EndQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ExpireDelegationTokenRequest => ExpireDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: FetchRequest => FetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: FindCoordinatorRequest => FindCoordinatorRequestDataJsonConverter.write(req.data, request.version)
+ case req: HeartbeatRequest => HeartbeatRequestDataJsonConverter.write(req.data, request.version)
+ case req: IncrementalAlterConfigsRequest => IncrementalAlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: InitProducerIdRequest => InitProducerIdRequestDataJsonConverter.write(req.data, request.version)
+ case req: JoinGroupRequest => JoinGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaderAndIsrRequest => LeaderAndIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaveGroupRequest => LeaveGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListGroupsRequest => ListGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListOffsetRequest => ListOffsetRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListPartitionReassignmentsRequest => ListPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: MetadataRequest => MetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetCommitRequest => OffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetDeleteRequest => OffsetDeleteRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetFetchRequest => OffsetFetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetsForLeaderEpochRequest => offsetsForLeaderEpochRequestNode(req, request.version)
+ case req: ProduceRequest => produceRequestNode(req, request.version)
+ case req: RenewDelegationTokenRequest => RenewDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslAuthenticateRequest => SaslAuthenticateRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslHandshakeRequest => SaslHandshakeRequestDataJsonConverter.write(req.data, request.version)
+ case req: StopReplicaRequest => StopReplicaRequestDataJsonConverter.write(req.data, request.version)
+ case req: SyncGroupRequest => SyncGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: TxnOffsetCommitRequest => TxnOffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateFeaturesRequest => UpdateFeaturesRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateMetadataRequest => UpdateMetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: VoteRequest => VoteRequestDataJsonConverter.write(req.data, request.version)
+ case req: WriteTxnMarkersRequest => WriteTxnMarkersRequestDataJsonConverter.write(req.data, request.version)
+ case _ => throw new AssertionError(s"ApiKey ${request.api} is not currently handled in `request`, the " +
Review comment:
`IllegaleStateException` sounds more appropriate here and below.
##########
File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala
##########
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.network
+
+import java.util
+
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, BinaryNode, DoubleNode, IntNode, JsonNodeFactory, LongNode, NullNode, ObjectNode, ShortNode, TextNode}
+import kafka.network.RequestChannel.{Response, Session}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.network.ClientInformation
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.record.RecordBatch
+import org.apache.kafka.common.requests._
+import org.apache.kafka.common.utils.CollectionUtils
+
+import scala.jdk.CollectionConverters._
+
+object RequestConvertToJson {
+ def request(request: AbstractRequest, verbose: Boolean): JsonNode = {
+ request match {
+ case req: AddOffsetsToTxnRequest => AddOffsetsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AddPartitionsToTxnRequest => AddPartitionsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterClientQuotasRequest => AlterClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterConfigsRequest => AlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterIsrRequest => AlterIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterPartitionReassignmentsRequest => AlterPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterReplicaLogDirsRequest => AlterReplicaLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case res: AlterUserScramCredentialsRequest => AlterUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ApiVersionsRequest => ApiVersionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: BeginQuorumEpochRequest => BeginQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ControlledShutdownRequest => ControlledShutdownRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateAclsRequest => CreateAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateDelegationTokenRequest => CreateDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreatePartitionsRequest => CreatePartitionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateTopicsRequest => CreateTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteAclsRequest => DeleteAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteGroupsRequest => DeleteGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteRecordsRequest => DeleteRecordsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteTopicsRequest => DeleteTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeAclsRequest => DescribeAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeClientQuotasRequest => DescribeClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeConfigsRequest => DescribeConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeDelegationTokenRequest => DescribeDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeGroupsRequest => DescribeGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeLogDirsRequest => DescribeLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeQuorumRequest => DescribeQuorumRequestDataJsonConverter.write(req.data, request.version)
+ case res: DescribeUserScramCredentialsRequest => DescribeUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ElectLeadersRequest => ElectLeadersRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndTxnRequest => EndTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndQuorumEpochRequest => EndQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ExpireDelegationTokenRequest => ExpireDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: FetchRequest => FetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: FindCoordinatorRequest => FindCoordinatorRequestDataJsonConverter.write(req.data, request.version)
+ case req: HeartbeatRequest => HeartbeatRequestDataJsonConverter.write(req.data, request.version)
+ case req: IncrementalAlterConfigsRequest => IncrementalAlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: InitProducerIdRequest => InitProducerIdRequestDataJsonConverter.write(req.data, request.version)
+ case req: JoinGroupRequest => JoinGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaderAndIsrRequest => LeaderAndIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaveGroupRequest => LeaveGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListGroupsRequest => ListGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListOffsetRequest => ListOffsetRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListPartitionReassignmentsRequest => ListPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: MetadataRequest => MetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetCommitRequest => OffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetDeleteRequest => OffsetDeleteRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetFetchRequest => OffsetFetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetsForLeaderEpochRequest => offsetsForLeaderEpochRequestNode(req, request.version)
+ case req: ProduceRequest => produceRequestNode(req, request.version)
+ case req: RenewDelegationTokenRequest => RenewDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslAuthenticateRequest => SaslAuthenticateRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslHandshakeRequest => SaslHandshakeRequestDataJsonConverter.write(req.data, request.version)
+ case req: StopReplicaRequest => StopReplicaRequestDataJsonConverter.write(req.data, request.version)
+ case req: SyncGroupRequest => SyncGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: TxnOffsetCommitRequest => TxnOffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateFeaturesRequest => UpdateFeaturesRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateMetadataRequest => UpdateMetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: VoteRequest => VoteRequestDataJsonConverter.write(req.data, request.version)
+ case req: WriteTxnMarkersRequest => WriteTxnMarkersRequestDataJsonConverter.write(req.data, request.version)
+ case _ => throw new AssertionError(s"ApiKey ${request.api} is not currently handled in `request`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def response(response: AbstractResponse, version: Short): JsonNode = {
+ response match {
+ case res: AddOffsetsToTxnResponse => AddOffsetsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AddPartitionsToTxnResponse => AddPartitionsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AlterClientQuotasResponse => AlterClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: AlterConfigsResponse => AlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterIsrResponse => AlterIsrResponseDataJsonConverter.write(res.data, version)
+ case res: AlterPartitionReassignmentsResponse => AlterPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterReplicaLogDirsResponse => AlterReplicaLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterUserScramCredentialsResponse => AlterUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ApiVersionsResponse => ApiVersionsResponseDataJsonConverter.write(res.data, version)
+ case res: BeginQuorumEpochResponse => BeginQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ControlledShutdownResponse => ControlledShutdownResponseDataJsonConverter.write(res.data, version)
+ case res: CreateAclsResponse => CreateAclsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateDelegationTokenResponse => CreateDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: CreatePartitionsResponse => CreatePartitionsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateTopicsResponse => CreateTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteAclsResponse => DeleteAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteGroupsResponse => DeleteGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteRecordsResponse => DeleteRecordsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteTopicsResponse => DeleteTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeAclsResponse => DescribeAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeClientQuotasResponse => DescribeClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeConfigsResponse => DescribeConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeDelegationTokenResponse => DescribeDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeGroupsResponse => DescribeGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeLogDirsResponse => DescribeLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeQuorumResponse => DescribeQuorumResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeUserScramCredentialsResponse => DescribeUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ElectLeadersResponse => ElectLeadersResponseDataJsonConverter.write(res.data, version)
+ case res: EndTxnResponse => EndTxnResponseDataJsonConverter.write(res.data, version)
+ case res: EndQuorumEpochResponse => EndQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ExpireDelegationTokenResponse => ExpireDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: FetchResponse[_] => FetchResponseDataJsonConverter.write(res.data, version)
+ case res: FindCoordinatorResponse => FindCoordinatorResponseDataJsonConverter.write(res.data, version)
+ case res: HeartbeatResponse => HeartbeatResponseDataJsonConverter.write(res.data, version)
+ case res: IncrementalAlterConfigsResponse => IncrementalAlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: InitProducerIdResponse => InitProducerIdResponseDataJsonConverter.write(res.data, version)
+ case res: JoinGroupResponse => JoinGroupResponseDataJsonConverter.write(res.data, version)
+ case res: LeaderAndIsrResponse => LeaderAndIsrResponseDataJsonConverter.write(res.data, version)
+ case res: LeaveGroupResponse => LeaveGroupResponseDataJsonConverter.write(res.data, version)
+ case res: ListGroupsResponse => ListGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: ListOffsetResponse => ListOffsetResponseDataJsonConverter.write(res.data, version)
+ case res: ListPartitionReassignmentsResponse => ListPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: MetadataResponse => MetadataResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetCommitResponse => OffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetDeleteResponse => OffsetDeleteResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetFetchResponse => OffsetFetchResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetsForLeaderEpochResponse => offsetsForLeaderEpochResponseNode(res, version)
+ case res: ProduceResponse => produceResponseNode(res, version)
+ case res: RenewDelegationTokenResponse => RenewDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: SaslAuthenticateResponse => SaslAuthenticateResponseDataJsonConverter.write(res.data, version)
+ case res: SaslHandshakeResponse => SaslHandshakeResponseDataJsonConverter.write(res.data, version)
+ case res: StopReplicaResponse => StopReplicaResponseDataJsonConverter.write(res.data, version)
+ case res: SyncGroupResponse => SyncGroupResponseDataJsonConverter.write(res.data, version)
+ case res: TxnOffsetCommitResponse => TxnOffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateFeaturesResponse => UpdateFeaturesResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateMetadataResponse => UpdateMetadataResponseDataJsonConverter.write(res.data, version)
+ case res: WriteTxnMarkersResponse => WriteTxnMarkersResponseDataJsonConverter.write(res.data, version)
+ case res: VoteResponse => VoteResponseDataJsonConverter.write(res.data, version)
+ case _ => throw new AssertionError(s"ApiKey $response is not currently handled in `response`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def requestHeaderNode(header: RequestHeader): JsonNode = {
+ val node = RequestHeaderDataJsonConverter.write(header.data(), header.headerVersion()).asInstanceOf[ObjectNode]
+ node.set("requestApiKeyName", new TextNode(header.apiKey.toString))
+ node
+ }
+
+ def clientInfoNode(clientInfo: ClientInformation): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("softwareName", new TextNode(clientInfo.softwareName()))
+ node.set("softwareName", new TextNode(clientInfo.softwareVersion()))
Review comment:
`softwareName` -> `softwareVersion`?
##########
File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala
##########
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.network
+
+import java.util
+
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, BinaryNode, DoubleNode, IntNode, JsonNodeFactory, LongNode, NullNode, ObjectNode, ShortNode, TextNode}
+import kafka.network.RequestChannel.{Response, Session}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.network.ClientInformation
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.record.RecordBatch
+import org.apache.kafka.common.requests._
+import org.apache.kafka.common.utils.CollectionUtils
+
+import scala.jdk.CollectionConverters._
+
+object RequestConvertToJson {
+ def request(request: AbstractRequest, verbose: Boolean): JsonNode = {
+ request match {
+ case req: AddOffsetsToTxnRequest => AddOffsetsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AddPartitionsToTxnRequest => AddPartitionsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterClientQuotasRequest => AlterClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterConfigsRequest => AlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterIsrRequest => AlterIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterPartitionReassignmentsRequest => AlterPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterReplicaLogDirsRequest => AlterReplicaLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case res: AlterUserScramCredentialsRequest => AlterUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ApiVersionsRequest => ApiVersionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: BeginQuorumEpochRequest => BeginQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ControlledShutdownRequest => ControlledShutdownRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateAclsRequest => CreateAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateDelegationTokenRequest => CreateDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreatePartitionsRequest => CreatePartitionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateTopicsRequest => CreateTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteAclsRequest => DeleteAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteGroupsRequest => DeleteGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteRecordsRequest => DeleteRecordsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteTopicsRequest => DeleteTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeAclsRequest => DescribeAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeClientQuotasRequest => DescribeClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeConfigsRequest => DescribeConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeDelegationTokenRequest => DescribeDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeGroupsRequest => DescribeGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeLogDirsRequest => DescribeLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeQuorumRequest => DescribeQuorumRequestDataJsonConverter.write(req.data, request.version)
+ case res: DescribeUserScramCredentialsRequest => DescribeUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ElectLeadersRequest => ElectLeadersRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndTxnRequest => EndTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndQuorumEpochRequest => EndQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ExpireDelegationTokenRequest => ExpireDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: FetchRequest => FetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: FindCoordinatorRequest => FindCoordinatorRequestDataJsonConverter.write(req.data, request.version)
+ case req: HeartbeatRequest => HeartbeatRequestDataJsonConverter.write(req.data, request.version)
+ case req: IncrementalAlterConfigsRequest => IncrementalAlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: InitProducerIdRequest => InitProducerIdRequestDataJsonConverter.write(req.data, request.version)
+ case req: JoinGroupRequest => JoinGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaderAndIsrRequest => LeaderAndIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaveGroupRequest => LeaveGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListGroupsRequest => ListGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListOffsetRequest => ListOffsetRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListPartitionReassignmentsRequest => ListPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: MetadataRequest => MetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetCommitRequest => OffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetDeleteRequest => OffsetDeleteRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetFetchRequest => OffsetFetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetsForLeaderEpochRequest => offsetsForLeaderEpochRequestNode(req, request.version)
+ case req: ProduceRequest => produceRequestNode(req, request.version)
+ case req: RenewDelegationTokenRequest => RenewDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslAuthenticateRequest => SaslAuthenticateRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslHandshakeRequest => SaslHandshakeRequestDataJsonConverter.write(req.data, request.version)
+ case req: StopReplicaRequest => StopReplicaRequestDataJsonConverter.write(req.data, request.version)
+ case req: SyncGroupRequest => SyncGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: TxnOffsetCommitRequest => TxnOffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateFeaturesRequest => UpdateFeaturesRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateMetadataRequest => UpdateMetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: VoteRequest => VoteRequestDataJsonConverter.write(req.data, request.version)
+ case req: WriteTxnMarkersRequest => WriteTxnMarkersRequestDataJsonConverter.write(req.data, request.version)
+ case _ => throw new AssertionError(s"ApiKey ${request.api} is not currently handled in `request`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def response(response: AbstractResponse, version: Short): JsonNode = {
+ response match {
+ case res: AddOffsetsToTxnResponse => AddOffsetsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AddPartitionsToTxnResponse => AddPartitionsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AlterClientQuotasResponse => AlterClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: AlterConfigsResponse => AlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterIsrResponse => AlterIsrResponseDataJsonConverter.write(res.data, version)
+ case res: AlterPartitionReassignmentsResponse => AlterPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterReplicaLogDirsResponse => AlterReplicaLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterUserScramCredentialsResponse => AlterUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ApiVersionsResponse => ApiVersionsResponseDataJsonConverter.write(res.data, version)
+ case res: BeginQuorumEpochResponse => BeginQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ControlledShutdownResponse => ControlledShutdownResponseDataJsonConverter.write(res.data, version)
+ case res: CreateAclsResponse => CreateAclsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateDelegationTokenResponse => CreateDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: CreatePartitionsResponse => CreatePartitionsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateTopicsResponse => CreateTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteAclsResponse => DeleteAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteGroupsResponse => DeleteGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteRecordsResponse => DeleteRecordsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteTopicsResponse => DeleteTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeAclsResponse => DescribeAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeClientQuotasResponse => DescribeClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeConfigsResponse => DescribeConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeDelegationTokenResponse => DescribeDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeGroupsResponse => DescribeGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeLogDirsResponse => DescribeLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeQuorumResponse => DescribeQuorumResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeUserScramCredentialsResponse => DescribeUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ElectLeadersResponse => ElectLeadersResponseDataJsonConverter.write(res.data, version)
+ case res: EndTxnResponse => EndTxnResponseDataJsonConverter.write(res.data, version)
+ case res: EndQuorumEpochResponse => EndQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ExpireDelegationTokenResponse => ExpireDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: FetchResponse[_] => FetchResponseDataJsonConverter.write(res.data, version)
+ case res: FindCoordinatorResponse => FindCoordinatorResponseDataJsonConverter.write(res.data, version)
+ case res: HeartbeatResponse => HeartbeatResponseDataJsonConverter.write(res.data, version)
+ case res: IncrementalAlterConfigsResponse => IncrementalAlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: InitProducerIdResponse => InitProducerIdResponseDataJsonConverter.write(res.data, version)
+ case res: JoinGroupResponse => JoinGroupResponseDataJsonConverter.write(res.data, version)
+ case res: LeaderAndIsrResponse => LeaderAndIsrResponseDataJsonConverter.write(res.data, version)
+ case res: LeaveGroupResponse => LeaveGroupResponseDataJsonConverter.write(res.data, version)
+ case res: ListGroupsResponse => ListGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: ListOffsetResponse => ListOffsetResponseDataJsonConverter.write(res.data, version)
+ case res: ListPartitionReassignmentsResponse => ListPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: MetadataResponse => MetadataResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetCommitResponse => OffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetDeleteResponse => OffsetDeleteResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetFetchResponse => OffsetFetchResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetsForLeaderEpochResponse => offsetsForLeaderEpochResponseNode(res, version)
+ case res: ProduceResponse => produceResponseNode(res, version)
+ case res: RenewDelegationTokenResponse => RenewDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: SaslAuthenticateResponse => SaslAuthenticateResponseDataJsonConverter.write(res.data, version)
+ case res: SaslHandshakeResponse => SaslHandshakeResponseDataJsonConverter.write(res.data, version)
+ case res: StopReplicaResponse => StopReplicaResponseDataJsonConverter.write(res.data, version)
+ case res: SyncGroupResponse => SyncGroupResponseDataJsonConverter.write(res.data, version)
+ case res: TxnOffsetCommitResponse => TxnOffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateFeaturesResponse => UpdateFeaturesResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateMetadataResponse => UpdateMetadataResponseDataJsonConverter.write(res.data, version)
+ case res: WriteTxnMarkersResponse => WriteTxnMarkersResponseDataJsonConverter.write(res.data, version)
+ case res: VoteResponse => VoteResponseDataJsonConverter.write(res.data, version)
+ case _ => throw new AssertionError(s"ApiKey $response is not currently handled in `response`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def requestHeaderNode(header: RequestHeader): JsonNode = {
+ val node = RequestHeaderDataJsonConverter.write(header.data(), header.headerVersion()).asInstanceOf[ObjectNode]
+ node.set("requestApiKeyName", new TextNode(header.apiKey.toString))
+ node
+ }
+
+ def clientInfoNode(clientInfo: ClientInformation): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("softwareName", new TextNode(clientInfo.softwareName()))
+ node.set("softwareName", new TextNode(clientInfo.softwareVersion()))
+ node
+ }
+
+ def requestDescMetrics(header: RequestHeader, res: Response, req: AbstractRequest,
+ context: RequestContext, session: Session, verbose: Boolean,
+ totalTimeMs: Double, requestQueueTimeMs: Double, apiLocalTimeMs: Double,
+ apiRemoteTimeMs: Double, apiThrottleTimeMs: Long, responseQueueTimeMs: Double,
+ responseSendTimeMs: Double, temporaryMemoryBytes: Long,
+ messageConversionsTimeMs: Double): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("requestHeader", requestHeaderNode(header))
+ node.set("request", request(req, verbose))
+ node.set("response", res.responseLog.getOrElse(new TextNode("")))
+ node.set("connection", new TextNode(context.connectionId))
+ node.set("totalTimeMs", new DoubleNode(totalTimeMs))
+ node.set("requestQueueTimeMs", new DoubleNode(requestQueueTimeMs))
+ node.set("localTimeMs", new DoubleNode(apiLocalTimeMs))
+ node.set("remoteTimeMs", new DoubleNode(apiRemoteTimeMs))
+ node.set("throttleTimeMs", new LongNode(apiThrottleTimeMs))
+ node.set("responseQueueTimeMs", new DoubleNode(responseQueueTimeMs))
+ node.set("sendTimeMs", new DoubleNode(responseSendTimeMs))
+ node.set("securityProtocol", new TextNode(context.securityProtocol.toString))
+ node.set("principal", new TextNode(session.principal.toString))
+ node.set("listener", new TextNode(context.listenerName.value))
+ node.set("clientInformation", clientInfoNode(context.clientInformation))
+ if (temporaryMemoryBytes > 0)
+ node.set("temporaryMemoryBytes", new LongNode(temporaryMemoryBytes))
+ if (messageConversionsTimeMs > 0)
+ node.set("messageConversionsTime", new DoubleNode(messageConversionsTimeMs))
+ node
+ }
+
+ def requestDesc(header: RequestHeader, req: AbstractRequest, verbose: Boolean): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("requestHeader", requestHeaderNode(header))
+ node.set("request", request(req, verbose))
+ node
+ }
+
+ /**
+ * Temporary until switch to use the generated schemas.
+ */
+ def offsetsForLeaderEpochRequestNode(request: OffsetsForLeaderEpochRequest, version: Short): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ if (version >= 3) {
+ node.set("replicaId", new IntNode(request.replicaId))
+ }
+ val topics = CollectionUtils.groupPartitionDataByTopic(request.epochsByTopicPartition)
+ val topicsArray = new ArrayNode(JsonNodeFactory.instance)
+ topics.forEach { (topicName, partitions) =>
+ val topicNode = new ObjectNode(JsonNodeFactory.instance)
+ topicNode.set("name", new TextNode(topicName))
+ val partitionsArray = new ArrayNode(JsonNodeFactory.instance)
+ partitions.forEach { (partitionIndex, partitionData) =>
+ val partitionNode = new ObjectNode(JsonNodeFactory.instance)
+ partitionNode.set("partitionIndex", new IntNode(partitionIndex))
+ if (version >= 2) {
+ val leaderEpoch = partitionData.currentLeaderEpoch
+ partitionNode.set("currentLeaderEpoch", new IntNode(leaderEpoch.orElse(RecordBatch.NO_PARTITION_LEADER_EPOCH)))
+ }
+ partitionNode.set("leaderEpoch", new IntNode(partitionData.leaderEpoch))
+ partitionsArray.add(partitionNode)
+ }
+ topicNode.set("partitions", partitionsArray)
+ topicsArray.add(topicNode)
+ }
+ node.set("topics", topicsArray)
+ node
+ }
+
+ /**
+ * Temporary until switch to use the generated schemas.
+ */
+ def produceRequestNode(request: ProduceRequest, version: Short): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ if (version >= 3) {
+ if (request.transactionalId == null) {
+ node.set("transactionalId", NullNode.instance)
+ } else {
+ node.set("transactionalId", new TextNode(request.transactionalId))
+ }
+ }
+ node.set("acks", new ShortNode(request.acks))
+ node.set("timeoutMs", new IntNode(request.timeout))
+ val topics = CollectionUtils.groupPartitionDataByTopic(request.partitionRecordsOrFail())
+ val topicsArray = new ArrayNode(JsonNodeFactory.instance)
+ topics.forEach { (topicName, partitions) =>
+ val topicNode = new ObjectNode(JsonNodeFactory.instance)
+ topicNode.set("name", new TextNode(topicName))
+ val partitionsArray = new ArrayNode(JsonNodeFactory.instance)
+ partitions.forEach { (partitionIndex, partitionData)=>
Review comment:
nit: Missing space before `=>`.
##########
File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala
##########
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.network
+
+import java.util
+
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, BinaryNode, DoubleNode, IntNode, JsonNodeFactory, LongNode, NullNode, ObjectNode, ShortNode, TextNode}
+import kafka.network.RequestChannel.{Response, Session}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.network.ClientInformation
+import org.apache.kafka.common.protocol.Errors
+import org.apache.kafka.common.record.RecordBatch
+import org.apache.kafka.common.requests._
+import org.apache.kafka.common.utils.CollectionUtils
+
+import scala.jdk.CollectionConverters._
+
+object RequestConvertToJson {
+ def request(request: AbstractRequest, verbose: Boolean): JsonNode = {
+ request match {
+ case req: AddOffsetsToTxnRequest => AddOffsetsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AddPartitionsToTxnRequest => AddPartitionsToTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterClientQuotasRequest => AlterClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterConfigsRequest => AlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterIsrRequest => AlterIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterPartitionReassignmentsRequest => AlterPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: AlterReplicaLogDirsRequest => AlterReplicaLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case res: AlterUserScramCredentialsRequest => AlterUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ApiVersionsRequest => ApiVersionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: BeginQuorumEpochRequest => BeginQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ControlledShutdownRequest => ControlledShutdownRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateAclsRequest => CreateAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateDelegationTokenRequest => CreateDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreatePartitionsRequest => CreatePartitionsRequestDataJsonConverter.write(req.data, request.version)
+ case req: CreateTopicsRequest => CreateTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteAclsRequest => DeleteAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteGroupsRequest => DeleteGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteRecordsRequest => DeleteRecordsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DeleteTopicsRequest => DeleteTopicsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeAclsRequest => DescribeAclsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeClientQuotasRequest => DescribeClientQuotasRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeConfigsRequest => DescribeConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeDelegationTokenRequest => DescribeDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeGroupsRequest => DescribeGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeLogDirsRequest => DescribeLogDirsRequestDataJsonConverter.write(req.data, request.version)
+ case req: DescribeQuorumRequest => DescribeQuorumRequestDataJsonConverter.write(req.data, request.version)
+ case res: DescribeUserScramCredentialsRequest => DescribeUserScramCredentialsRequestDataJsonConverter.write(res.data, request.version)
+ case req: ElectLeadersRequest => ElectLeadersRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndTxnRequest => EndTxnRequestDataJsonConverter.write(req.data, request.version)
+ case req: EndQuorumEpochRequest => EndQuorumEpochRequestDataJsonConverter.write(req.data, request.version)
+ case req: ExpireDelegationTokenRequest => ExpireDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: FetchRequest => FetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: FindCoordinatorRequest => FindCoordinatorRequestDataJsonConverter.write(req.data, request.version)
+ case req: HeartbeatRequest => HeartbeatRequestDataJsonConverter.write(req.data, request.version)
+ case req: IncrementalAlterConfigsRequest => IncrementalAlterConfigsRequestDataJsonConverter.write(req.data, request.version)
+ case req: InitProducerIdRequest => InitProducerIdRequestDataJsonConverter.write(req.data, request.version)
+ case req: JoinGroupRequest => JoinGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaderAndIsrRequest => LeaderAndIsrRequestDataJsonConverter.write(req.data, request.version)
+ case req: LeaveGroupRequest => LeaveGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListGroupsRequest => ListGroupsRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListOffsetRequest => ListOffsetRequestDataJsonConverter.write(req.data, request.version)
+ case req: ListPartitionReassignmentsRequest => ListPartitionReassignmentsRequestDataJsonConverter.write(req.data, request.version)
+ case req: MetadataRequest => MetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetCommitRequest => OffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetDeleteRequest => OffsetDeleteRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetFetchRequest => OffsetFetchRequestDataJsonConverter.write(req.data, request.version)
+ case req: OffsetsForLeaderEpochRequest => offsetsForLeaderEpochRequestNode(req, request.version)
+ case req: ProduceRequest => produceRequestNode(req, request.version)
+ case req: RenewDelegationTokenRequest => RenewDelegationTokenRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslAuthenticateRequest => SaslAuthenticateRequestDataJsonConverter.write(req.data, request.version)
+ case req: SaslHandshakeRequest => SaslHandshakeRequestDataJsonConverter.write(req.data, request.version)
+ case req: StopReplicaRequest => StopReplicaRequestDataJsonConverter.write(req.data, request.version)
+ case req: SyncGroupRequest => SyncGroupRequestDataJsonConverter.write(req.data, request.version)
+ case req: TxnOffsetCommitRequest => TxnOffsetCommitRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateFeaturesRequest => UpdateFeaturesRequestDataJsonConverter.write(req.data, request.version)
+ case req: UpdateMetadataRequest => UpdateMetadataRequestDataJsonConverter.write(req.data, request.version)
+ case req: VoteRequest => VoteRequestDataJsonConverter.write(req.data, request.version)
+ case req: WriteTxnMarkersRequest => WriteTxnMarkersRequestDataJsonConverter.write(req.data, request.version)
+ case _ => throw new AssertionError(s"ApiKey ${request.api} is not currently handled in `request`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def response(response: AbstractResponse, version: Short): JsonNode = {
+ response match {
+ case res: AddOffsetsToTxnResponse => AddOffsetsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AddPartitionsToTxnResponse => AddPartitionsToTxnResponseDataJsonConverter.write(res.data, version)
+ case res: AlterClientQuotasResponse => AlterClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: AlterConfigsResponse => AlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterIsrResponse => AlterIsrResponseDataJsonConverter.write(res.data, version)
+ case res: AlterPartitionReassignmentsResponse => AlterPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterReplicaLogDirsResponse => AlterReplicaLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: AlterUserScramCredentialsResponse => AlterUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ApiVersionsResponse => ApiVersionsResponseDataJsonConverter.write(res.data, version)
+ case res: BeginQuorumEpochResponse => BeginQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ControlledShutdownResponse => ControlledShutdownResponseDataJsonConverter.write(res.data, version)
+ case res: CreateAclsResponse => CreateAclsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateDelegationTokenResponse => CreateDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: CreatePartitionsResponse => CreatePartitionsResponseDataJsonConverter.write(res.data, version)
+ case res: CreateTopicsResponse => CreateTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteAclsResponse => DeleteAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteGroupsResponse => DeleteGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteRecordsResponse => DeleteRecordsResponseDataJsonConverter.write(res.data, version)
+ case res: DeleteTopicsResponse => DeleteTopicsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeAclsResponse => DescribeAclsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeClientQuotasResponse => DescribeClientQuotasResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeConfigsResponse => DescribeConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeDelegationTokenResponse => DescribeDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeGroupsResponse => DescribeGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeLogDirsResponse => DescribeLogDirsResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeQuorumResponse => DescribeQuorumResponseDataJsonConverter.write(res.data, version)
+ case res: DescribeUserScramCredentialsResponse => DescribeUserScramCredentialsResponseDataJsonConverter.write(res.data, version)
+ case res: ElectLeadersResponse => ElectLeadersResponseDataJsonConverter.write(res.data, version)
+ case res: EndTxnResponse => EndTxnResponseDataJsonConverter.write(res.data, version)
+ case res: EndQuorumEpochResponse => EndQuorumEpochResponseDataJsonConverter.write(res.data, version)
+ case res: ExpireDelegationTokenResponse => ExpireDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: FetchResponse[_] => FetchResponseDataJsonConverter.write(res.data, version)
+ case res: FindCoordinatorResponse => FindCoordinatorResponseDataJsonConverter.write(res.data, version)
+ case res: HeartbeatResponse => HeartbeatResponseDataJsonConverter.write(res.data, version)
+ case res: IncrementalAlterConfigsResponse => IncrementalAlterConfigsResponseDataJsonConverter.write(res.data, version)
+ case res: InitProducerIdResponse => InitProducerIdResponseDataJsonConverter.write(res.data, version)
+ case res: JoinGroupResponse => JoinGroupResponseDataJsonConverter.write(res.data, version)
+ case res: LeaderAndIsrResponse => LeaderAndIsrResponseDataJsonConverter.write(res.data, version)
+ case res: LeaveGroupResponse => LeaveGroupResponseDataJsonConverter.write(res.data, version)
+ case res: ListGroupsResponse => ListGroupsResponseDataJsonConverter.write(res.data, version)
+ case res: ListOffsetResponse => ListOffsetResponseDataJsonConverter.write(res.data, version)
+ case res: ListPartitionReassignmentsResponse => ListPartitionReassignmentsResponseDataJsonConverter.write(res.data, version)
+ case res: MetadataResponse => MetadataResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetCommitResponse => OffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetDeleteResponse => OffsetDeleteResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetFetchResponse => OffsetFetchResponseDataJsonConverter.write(res.data, version)
+ case res: OffsetsForLeaderEpochResponse => offsetsForLeaderEpochResponseNode(res, version)
+ case res: ProduceResponse => produceResponseNode(res, version)
+ case res: RenewDelegationTokenResponse => RenewDelegationTokenResponseDataJsonConverter.write(res.data, version)
+ case res: SaslAuthenticateResponse => SaslAuthenticateResponseDataJsonConverter.write(res.data, version)
+ case res: SaslHandshakeResponse => SaslHandshakeResponseDataJsonConverter.write(res.data, version)
+ case res: StopReplicaResponse => StopReplicaResponseDataJsonConverter.write(res.data, version)
+ case res: SyncGroupResponse => SyncGroupResponseDataJsonConverter.write(res.data, version)
+ case res: TxnOffsetCommitResponse => TxnOffsetCommitResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateFeaturesResponse => UpdateFeaturesResponseDataJsonConverter.write(res.data, version)
+ case res: UpdateMetadataResponse => UpdateMetadataResponseDataJsonConverter.write(res.data, version)
+ case res: WriteTxnMarkersResponse => WriteTxnMarkersResponseDataJsonConverter.write(res.data, version)
+ case res: VoteResponse => VoteResponseDataJsonConverter.write(res.data, version)
+ case _ => throw new AssertionError(s"ApiKey $response is not currently handled in `response`, the " +
+ "code should be updated to do so.");
+ }
+ }
+
+ def requestHeaderNode(header: RequestHeader): JsonNode = {
+ val node = RequestHeaderDataJsonConverter.write(header.data(), header.headerVersion()).asInstanceOf[ObjectNode]
+ node.set("requestApiKeyName", new TextNode(header.apiKey.toString))
+ node
+ }
+
+ def clientInfoNode(clientInfo: ClientInformation): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("softwareName", new TextNode(clientInfo.softwareName()))
+ node.set("softwareName", new TextNode(clientInfo.softwareVersion()))
+ node
+ }
+
+ def requestDescMetrics(header: RequestHeader, res: Response, req: AbstractRequest,
+ context: RequestContext, session: Session, verbose: Boolean,
+ totalTimeMs: Double, requestQueueTimeMs: Double, apiLocalTimeMs: Double,
+ apiRemoteTimeMs: Double, apiThrottleTimeMs: Long, responseQueueTimeMs: Double,
+ responseSendTimeMs: Double, temporaryMemoryBytes: Long,
+ messageConversionsTimeMs: Double): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("requestHeader", requestHeaderNode(header))
+ node.set("request", request(req, verbose))
+ node.set("response", res.responseLog.getOrElse(new TextNode("")))
+ node.set("connection", new TextNode(context.connectionId))
+ node.set("totalTimeMs", new DoubleNode(totalTimeMs))
+ node.set("requestQueueTimeMs", new DoubleNode(requestQueueTimeMs))
+ node.set("localTimeMs", new DoubleNode(apiLocalTimeMs))
+ node.set("remoteTimeMs", new DoubleNode(apiRemoteTimeMs))
+ node.set("throttleTimeMs", new LongNode(apiThrottleTimeMs))
+ node.set("responseQueueTimeMs", new DoubleNode(responseQueueTimeMs))
+ node.set("sendTimeMs", new DoubleNode(responseSendTimeMs))
+ node.set("securityProtocol", new TextNode(context.securityProtocol.toString))
+ node.set("principal", new TextNode(session.principal.toString))
+ node.set("listener", new TextNode(context.listenerName.value))
+ node.set("clientInformation", clientInfoNode(context.clientInformation))
+ if (temporaryMemoryBytes > 0)
+ node.set("temporaryMemoryBytes", new LongNode(temporaryMemoryBytes))
+ if (messageConversionsTimeMs > 0)
+ node.set("messageConversionsTime", new DoubleNode(messageConversionsTimeMs))
+ node
+ }
+
+ def requestDesc(header: RequestHeader, req: AbstractRequest, verbose: Boolean): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ node.set("requestHeader", requestHeaderNode(header))
+ node.set("request", request(req, verbose))
+ node
+ }
+
+ /**
+ * Temporary until switch to use the generated schemas.
+ */
+ def offsetsForLeaderEpochRequestNode(request: OffsetsForLeaderEpochRequest, version: Short): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ if (version >= 3) {
+ node.set("replicaId", new IntNode(request.replicaId))
+ }
+ val topics = CollectionUtils.groupPartitionDataByTopic(request.epochsByTopicPartition)
+ val topicsArray = new ArrayNode(JsonNodeFactory.instance)
+ topics.forEach { (topicName, partitions) =>
+ val topicNode = new ObjectNode(JsonNodeFactory.instance)
+ topicNode.set("name", new TextNode(topicName))
+ val partitionsArray = new ArrayNode(JsonNodeFactory.instance)
+ partitions.forEach { (partitionIndex, partitionData) =>
+ val partitionNode = new ObjectNode(JsonNodeFactory.instance)
+ partitionNode.set("partitionIndex", new IntNode(partitionIndex))
+ if (version >= 2) {
+ val leaderEpoch = partitionData.currentLeaderEpoch
+ partitionNode.set("currentLeaderEpoch", new IntNode(leaderEpoch.orElse(RecordBatch.NO_PARTITION_LEADER_EPOCH)))
+ }
+ partitionNode.set("leaderEpoch", new IntNode(partitionData.leaderEpoch))
+ partitionsArray.add(partitionNode)
+ }
+ topicNode.set("partitions", partitionsArray)
+ topicsArray.add(topicNode)
+ }
+ node.set("topics", topicsArray)
+ node
+ }
+
+ /**
+ * Temporary until switch to use the generated schemas.
+ */
+ def produceRequestNode(request: ProduceRequest, version: Short): JsonNode = {
+ val node = new ObjectNode(JsonNodeFactory.instance)
+ if (version >= 3) {
+ if (request.transactionalId == null) {
+ node.set("transactionalId", NullNode.instance)
+ } else {
+ node.set("transactionalId", new TextNode(request.transactionalId))
+ }
+ }
+ node.set("acks", new ShortNode(request.acks))
+ node.set("timeoutMs", new IntNode(request.timeout))
+ val topics = CollectionUtils.groupPartitionDataByTopic(request.partitionRecordsOrFail())
+ val topicsArray = new ArrayNode(JsonNodeFactory.instance)
+ topics.forEach { (topicName, partitions) =>
+ val topicNode = new ObjectNode(JsonNodeFactory.instance)
+ topicNode.set("name", new TextNode(topicName))
+ val partitionsArray = new ArrayNode(JsonNodeFactory.instance)
+ partitions.forEach { (partitionIndex, partitionData)=>
+ val partitionNode = new ObjectNode(JsonNodeFactory.instance)
+ partitionNode.set("partitionIndex", new IntNode(partitionIndex))
+ if (partitionData == null)
+ partitionNode.set("records", NullNode.instance)
+ else
+ partitionNode.set("records", new BinaryNode(util.Arrays.copyOf(partitionData.buffer().array(), partitionData.validBytes())))
Review comment:
This is not consistent with the changes that have been made in the automated protocol.
##########
File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java
##########
@@ -380,8 +380,9 @@ private void generateVariableLengthTargetToJson(Target target, Versions versions
target.sourceVariable(), target.sourceVariable())));
}
} else if (target.field().type().isRecords()) {
- headerGenerator.addImport(MessageGenerator.BINARY_NODE_CLASS);
- buffer.printf("%s;%n", target.assignmentStatement("new BinaryNode(new byte[]{})"));
+ headerGenerator.addImport(MessageGenerator.INT_NODE_CLASS);
+ buffer.printf("%s;%n", target.assignmentStatement(
+ String.format("new IntNode(%s.sizeInBytes())", target.sourceVariable())));
Review comment:
I am not entirely convinced by this change. The aim of the auto-generated protocol is to serialize/deserialise the requests/responses. Thus, it is a little weird that we only retain the size when serializing records to JSON and we actually expect bytes when deserializing from JSON. We are not consistent.
I can think of the following alternatives:
1) We keep exceptions for both the produce request and the fetch response in `RequestConvertToJson` where we could add a `recordsSizeInBytes` field instead of the `records` field.
2) We could post-process the JSON tree where we could discard `records` and add `recordsSizeInBytes`.
3) We could extend the autogenerated protocol to do only retain the size based on a flag. I am thinking about a `verbose` flag like we had before.
I lean towards 3) at the moment. By default, we should keep the current behavior and only retains the size when `verbose` is `false`. We may find a better name than `verbose` though.
@anatasiavela @lbradstreet Would this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org