You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Deepal Jayasinghe (JIRA)" <ji...@apache.org> on 2006/12/06 23:58:22 UTC

[jira] Created: (AXIS2-1841) Duplicate code in OperationClient

Duplicate code in OperationClient 
----------------------------------

                 Key: AXIS2-1841
                 URL: http://issues.apache.org/jira/browse/AXIS2-1841
             Project: Apache Axis 2.0 (Axis2)
          Issue Type: Improvement
          Components: client-api
    Affects Versions: 1.2
            Reporter: Deepal Jayasinghe


Glen and I went through client side code base and found out that there are multiple places we have duplicate codes , and the solution we came up with listed below;
- We can convert OperationClient interface to an abstract class and move the constructor code the abstract class .
- Move duplicate code inside the execute method to a utility class or somewhere 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Assigned: (AXIS2-1841) Duplicate code in OperationClient

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-1841?page=all ]

Davanum Srinivas reassigned AXIS2-1841:
---------------------------------------

    Assignee: Davanum Srinivas

> Duplicate code in OperationClient
> ---------------------------------
>
>                 Key: AXIS2-1841
>                 URL: http://issues.apache.org/jira/browse/AXIS2-1841
>             Project: Apache Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: client-api
>    Affects Versions: 1.2
>            Reporter: Deepal Jayasinghe
>         Assigned To: Davanum Srinivas
>         Attachments: AXIS2-1841.patch
>
>
> Glen and I went through client side code base and found out that there are multiple places we have duplicate codes , and the solution we came up with listed below;
> - We can convert OperationClient interface to an abstract class and move the constructor code the abstract class .
> - Move duplicate code inside the execute method to a utility class or somewhere 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-1841) Duplicate code in OperationClient

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-1841?page=all ]

Deepal Jayasinghe updated AXIS2-1841:
-------------------------------------

    Attachment: AXIS2-1841.patch

Hi Dims;
Here is the patch that remove duplicate code in client side. This patch contains following major changes
Introduce new class call TwoChannelAxisOperation , parent class for bot inout and outin AxisOperation
Convert  OperationClient to an abstract class

So pls go through the patch and let me know what need to be done.

Thanks
Deepal

> Duplicate code in OperationClient
> ---------------------------------
>
>                 Key: AXIS2-1841
>                 URL: http://issues.apache.org/jira/browse/AXIS2-1841
>             Project: Apache Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: client-api
>    Affects Versions: 1.2
>            Reporter: Deepal Jayasinghe
>         Attachments: AXIS2-1841.patch
>
>
> Glen and I went through client side code base and found out that there are multiple places we have duplicate codes , and the solution we came up with listed below;
> - We can convert OperationClient interface to an abstract class and move the constructor code the abstract class .
> - Move duplicate code inside the execute method to a utility class or somewhere 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-1841) Duplicate code in OperationClient

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-1841?page=all ]

Deepal Jayasinghe updated AXIS2-1841:
-------------------------------------

    Attachment: AXIS2-1841-new.patch

Attached the new patch

> Duplicate code in OperationClient
> ---------------------------------
>
>                 Key: AXIS2-1841
>                 URL: http://issues.apache.org/jira/browse/AXIS2-1841
>             Project: Apache Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: client-api
>    Affects Versions: 1.2
>            Reporter: Deepal Jayasinghe
>         Assigned To: Davanum Srinivas
>         Attachments: AXIS2-1841-new.patch, AXIS2-1841.patch
>
>
> Glen and I went through client side code base and found out that there are multiple places we have duplicate codes , and the solution we came up with listed below;
> - We can convert OperationClient interface to an abstract class and move the constructor code the abstract class .
> - Move duplicate code inside the execute method to a utility class or somewhere 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-1841) Duplicate code in OperationClient

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-1841?page=all ]

Davanum Srinivas resolved AXIS2-1841.
-------------------------------------

    Resolution: Fixed

Applied.

thanks,
dims

> Duplicate code in OperationClient
> ---------------------------------
>
>                 Key: AXIS2-1841
>                 URL: http://issues.apache.org/jira/browse/AXIS2-1841
>             Project: Apache Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: client-api
>    Affects Versions: 1.2
>            Reporter: Deepal Jayasinghe
>         Assigned To: Davanum Srinivas
>         Attachments: AXIS2-1841-new.patch, AXIS2-1841.patch
>
>
> Glen and I went through client side code base and found out that there are multiple places we have duplicate codes , and the solution we came up with listed below;
> - We can convert OperationClient interface to an abstract class and move the constructor code the abstract class .
> - Move duplicate code inside the execute method to a utility class or somewhere 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org