You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2024/02/14 13:17:40 UTC
Re: [PR] chore: Load test users as a precursor to running Python tests [superset]
michael-s-molina commented on code in PR #27108:
URL: https://github.com/apache/superset/pull/27108#discussion_r1489448855
##########
tox.ini:
##########
@@ -23,6 +23,7 @@ ignore_basepython_conflict = true
commands =
superset db upgrade
superset init
+ superset load-test-users
Review Comment:
This order is different than the one specified by [Integration Testing](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#integration-testing) in `CONTRIBUTING.md`.
In the same file we have:
```
# Create default roles and permissions
superset init
```
Could you check if only the roles and permissions are created by `superset init` but not their associations with users? If the associations are also handled by `superset init` we would need to load the test users before that step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org