You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/09 10:52:12 UTC
[GitHub] [skywalking-banyandb] lujiajing1126 opened a new pull request #31: Avoid Duration conflict in java
lujiajing1126 opened a new pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31
Signed-off-by: Megrez Lu <lu...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895135390
You said in Java, different proto files could have different Java package name, which could avoid this conflicts.
Duplicate names are common, SkyWalking network proto could conflict with each other or banyandb too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #31: Fix duplicate type names in proto
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895662169
> It looks like only Go, protobuf native language, doesn't have this issue 😅
It is only go generator unreasonable fix. Like many go tools do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #31: Fix duplicate type names in proto
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895141549
> Same name? How go compiling passed? This seems not working in any language.
Seems strange, the compiler automatically adds prefixes to the enum values,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #31: Fix duplicate type names in proto
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895152828
> OK, and rename title and make change log corret.
> Fix duplicate type names in proto.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895137040
> You said in Java, different proto files could have different Java package name, which could avoid this conflicts.
> Duplicate names are common, SkyWalking network proto could conflict with each other or banyandb too.
Emmm, but they are in the same file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 edited a comment on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
lujiajing1126 edited a comment on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895141549
> Same name? How go compiling passed? This seems not working in any language.
Seems strange, the compiler automatically adds prefixes to the enum values in Golang,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895133742
> Renaming is not the key. Add namespace and java package option.
> Take a reference from SkyWalking protocol repository.
Sorry, I am confused. I suppose the conflict is due to the duplicated name for both Enum and Message defined in the `schema.proto`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895138628
Same name? How go compiling passed? This seems not working in any language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895130331
Renaming is not the key. Add namespace and java package option.
Take a reference from SkyWalking protocol repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #31: Avoid Duration conflict in java
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #31:
URL: https://github.com/apache/skywalking-banyandb/pull/31#issuecomment-895142405
OK, and rename title and make change log corret.
Fix duplicate type names in proto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org