You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/22 02:13:35 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #39164: [SPARK-41432][UI][SQL] Protobuf serializer for SparkPlanGraphWrapper

LuciferYang commented on code in PR #39164:
URL: https://github.com/apache/spark/pull/39164#discussion_r1055018553


##########
sql/core/pom.xml:
##########
@@ -291,5 +297,68 @@
         </dependency>
       </dependencies>
     </profile>
+    <profile>

Review Comment:
   I think we should also shaded and relocation `protobuf-java` in sql module, like 
   
   https://github.com/LuciferYang/spark/blob/ef9c8e0d045576fb325ef337319fe6d59b7ce858/core/pom.xml#L691-L694



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org