You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/07/23 12:28:45 UTC
[GitHub] [incubator-weex] wqyfavor commented on a change in pull request
#2731: Add Lint in TravisCI and Update iOS TravisCI
wqyfavor commented on a change in pull request #2731: Add Lint in TravisCI and Update iOS TravisCI
URL: https://github.com/apache/incubator-weex/pull/2731#discussion_r306289684
##########
File path: ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
##########
@@ -396,12 +396,9 @@ - (void)_renderWithData:(NSData *)contents
}
self.performance.renderTimeOrigin = CACurrentMediaTime()*1000;
- self.performance.renderUnixTimeOrigin = [WXUtility getUnixFixTimeMillis];
- long renderOriginTimePlatform = [self.apmInstance onStage:KEY_PAGE_STAGES_RENDER_ORGIGIN];
-
- // pass render origin time to page
[WXCoreBridge setPageArgument:_instanceId key:@"renderTimeOrigin" value:[NSString stringWithFormat:@"%lld", (long long)([[NSDate date] timeIntervalSince1970] * 1000)]];
- [WXCoreBridge setPageArgument:_instanceId key:@"renderTimeOriginPlatform" value:[NSString stringWithFormat:@"%lld", (long long)renderOriginTimePlatform]];
+ self.performance.renderUnixTimeOrigin = [WXUtility getUnixFixTimeMillis];
+ [self.apmInstance onStage:KEY_PAGE_STAGES_RENDER_ORGIGIN];
Review comment:
This breaks previous commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services