You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/19 01:35:55 UTC
[GitHub] [airflow] kaxil opened a new pull request #11023: Get Airflow configs with sensitive data from AWS Systems Manager
kaxil opened a new pull request #11023:
URL: https://github.com/apache/airflow/pull/11023
Adds support to AWS SSM for feature added in https://github.com/apache/airflow/pull/9645
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11023: Get Airflow configs with sensitive data from AWS Systems Manager
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11023:
URL: https://github.com/apache/airflow/pull/11023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11023: Get Airflow configs with sensitive data from AWS Systems Manager
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11023:
URL: https://github.com/apache/airflow/pull/11023#issuecomment-695339297
> Nice. Will that work however before secret backend is initialized? It is initialised in config, so just wondering if there is no "chicken-egg" problem here.
Yup it will continue to work. `_get_config_value_from_secret_backend` will be called which will take care of initialization too :)
https://github.com/apache/airflow/blob/d7f166606e3425bb3e1fc380623d428badcd159e/airflow/configuration.py#L91-L96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org