[GitHub] [incubator-superset] zhaoyongjie commented on a change in pull request #10977: Minor refactor, remove unreachable codes

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #10977:
URL: https://github.com/apache/incubator-superset/pull/10977#discussion_r492443662



##########
File path: superset/charts/api.py
##########
@@ -469,20 +471,21 @@ def data(self) -> Response:
             return self.response_400(
                 message=_("Request is incorrect: %(error)s", error=error.messages)
             )
+
+        # ACL control
         try:
             query_context.raise_for_access()
         except SupersetSecurityException:
             return self.response_401()
+
+        # get all query payload
         payload = query_context.get_payload()
         for query in payload:
             if query.get("error"):
                 return self.response_400(message=f"Error: {query['error']}")
-        result_format = query_context.result_format
-
-        response = self.response_400(
-            message=f"Unsupported result_format: {result_format}"
-        )
 
+        result_format = query_context.result_format
+        response = None

Review comment:
       this expression is unreachable `response = self.response_400(message=f"Unsupported result_format: {result_format}")`  , because marshmallow validate method can raise exception when request is unexpect.
   
   can we move all try...catch express to marshmallow logic?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org