[jira] Commented: (MRELEASE-128) SCM properties being replaced during release:perform

["Steve Tarver (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MRELEASE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150804#action_150804 ] 

Steve Tarver commented on MRELEASE-128:
---------------------------------------

Emmanuel,

I believe this is still broken in RewritePomsForDevelopmentPhase.transformScm(). The RewritePomsForReleasePhase.transformScm() works fine (note releaseConfiguration.mapOriginalScmInfo( projectId, project.getScm() );) , but values after string substitution are still used when prepping for the next development phase.

Here are changes on my pom that were committed to cvs over the prepare-perform cycle (replaced some parts with <...>)

  <scm>
    <connection>scm:cvs:ext:${scm.username}@<...></connection>
    <developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
    <url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
  </scm>

  <scm>
    <connection>scm:cvs:ext:${scm.username}@<...></connection>
    <developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
    <url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
    <tag>oss-ticket-api-1_0_29</tag>
  </scm>

  <scm>
    <connection>scm:cvs:ext:starver@<...></connection>
    <developerConnection>scm:cvs:ext:starver@<...></developerConnection>
    <url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
  </scm>


> SCM properties being replaced during release:perform
> ----------------------------------------------------
>
>                 Key: MRELEASE-128
>                 URL: http://jira.codehaus.org/browse/MRELEASE-128
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>         Environment: Windows XP client, Linux repo, CVS, Maven 2.0.4
>            Reporter: Craig Dickson
>            Assignee: Emmanuel Venisse
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: after-release-perform-pom.xml, after-release-prepre-pom.xml, MNG-128-maven-release-manager.patch, MRELEASE-128_cvs_hack_RewritePomsForDevelopmentPhase.java.patch, original-pom.xml
>
>
> The <scm> section of a pom in CVS for a pom archetype project looks like this prior to executing release:prepare :
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> </scm>
> Then after executing release:prepare, the pom in CVS looks like this (new <tag> tag is only difference):
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> 	<tag>R-1_7</tag>
> </scm>
> Then after executing release:perform, the pom looks like this in CVS:
> <scm>
> 	<connection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</connection>
> 	<developerConnection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</developerConnection>
> 	<url>http://behrcvs.masco-coatings.com/cgi-bin/viewcvs.cgi/commons-maven/uber-pom</url>
> </scm>
> Notice that the properties that were there for the base URLs for CVS and ViewCVS have been replaced with literal values. 
> No other properties in the POM are being replaced

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira