You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Johan Corveleyn <jc...@gmail.com> on 2020/12/17 10:59:54 UTC

Re: [PATCH] Support APR 1.4 for building on CentOS 7

On Wed, Sep 23, 2020 at 5:05 PM Julian Foad <ju...@apache.org> wrote:
>
> Committed in r1881958.
>
> BTW, how I tested this is by cleaning my build:
>
>    (cd obj-dir && make local-clean)
>
> and then rebuilding, adding the following options to configure:
>
>    --with-apr=$HOME/.local/apr-1.4.8
> --with-apr-util=$HOME/.local/apr-util-1.5.2
>
> with local builds of apr and apr-util in the stated places.
>
> - Julian

Hi Julian,

I quickly wanted to point out that the backport-proposal of this
change to 1.14.x is missing one vote, and that your own vote isn't
"complete", because the proposal was later amended with r1882128 (to
silence a warning on OSX) -- so your own vote was annotated with
"(only r1881958)". So if you'd have some time, and could take another
look ... if you can "upgrade" your backport vote this would be enough
for approval I suppose.

(just skimming through STATUS to see what's close to the finish line ...)
-- 
Johan

Re: [PATCH] Support APR 1.4 for building on CentOS 7

Posted by Julian Foad <ju...@apache.org>.
Johan Corveleyn wrote on 2020-12-17:
> I quickly wanted to point out that the backport-proposal of this
> change to 1.14.x is missing one vote, and that your own vote isn't
> "complete", because the proposal was later amended [...]

Thank you for the heads-up, Johan. Reviewed and approved.

-- 
- Julian