[jira] [Commented] (CB-13831) Update `android-versions` npm dependency to support Android API 27.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339593#comment-16339593 ] 

ASF GitHub Bot commented on CB-13831:
-------------------------------------

abernix opened a new pull request #430: CB-13831: (android) Update `android-versions` to 1.3.0 to support SDK 27.
URL: https://github.com/apache/cordova-android/pull/430
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Updates `android-versions` to the latest version, 1.3.0, which is aware of the existence of Android API level 27, thanks to https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc.
   
   As the `android-versions` npm is a "bundled dependency" this will only
   take effect when a new version of `cordova-android` is published, since
   bundled dependencies are packed within the npm at publish time, not
   automatically fetched as dependencies at publish time (which would have
   normally been covered for new installations of cordova-android@7.0.0
   thanks to semver caret notation).
   
   ### What testing has been done on this change?
   
   * `npm test`
   * Confirm that the emulator (i.e. `cordova run android --emulator -d`) will actually launch.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
     - Presumably covered by the old tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update `android-versions` npm dependency to support Android API 27.
> -------------------------------------------------------------------
>
>                 Key: CB-13831
>                 URL: https://issues.apache.org/jira/browse/CB-13831
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-android
>            Reporter: Jesse Rosenberger
>            Assignee: Joe Bowser
>            Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via {{package.json}}'s {{bundledDependencies}} attribute) a version of the [{{android-versions}} npm|https://npm.im/android-versions] which doesn't support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if API level 27 is installed, which is the default SDK for a new installation of Android Studio.  It also contributed to the error seen in CB-13571, though that will prevent the same error from occurring in the future if an additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does support level 27 (now, thanks to [this recent commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]), the fact that it is a so-called "bundled dependency" means the current version (1.2.1) is baked into the {{cordova-android}} installation tarball, and won't automatically respect the caret version range (`^1.2.1`) listed in {{cordova-android}}`s {{package.json}}, despite the lack of a {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s {{package.json}} to 1.3.0 will enable the emulator to work with API level 27 (even if there _could_ be other reasons that API level 27 causes problems).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org