You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/09 15:15:00 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#4678: Remove long sql test case
SteNicholas opened a new pull request #4678: Remove long sql test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4678
Fixes #4426.
Stack overflow caused by long sql test case for `SQLParserParameterizedTest` should be resolved by modify `-XSS` of JVM option. The reason for this exception is that there are many levels of recursion for visiting `Expr`. There are two ways to solve this problem, one is to change the recursion into a loop, which brings a lot of work, and the other is to adjust the `-XSS` option. Therefore, long sql test case could be removed, and adjust `-XSS` of JVM option to solve the stack overflow.
Changes proposed in this pull request:
- Remove long sql test sql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4678:
Remove long sql test case
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4678: Remove long sql test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4678#issuecomment-596610541
## Pull Request Test Coverage Report for [Build 10144](https://coveralls.io/builds/29225557)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **18** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **59.035%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29225557/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29225557/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29225557/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
<!-- | **Total:** | **18** | | -->
| Totals | [](https://coveralls.io/builds/29225557) |
| :-- | --: |
| Change from base [Build 1032](https://coveralls.io/builds/29221949): | -0.08% |
| Covered Lines: | 12111 |
| Relevant Lines: | 20515 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4678: Remove long sql test case
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4678: Remove long sql test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4678#issuecomment-596610541
## Pull Request Test Coverage Report for [Build 2047](https://coveralls.io/builds/29225674)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **59.113%**
---
| Totals | [](https://coveralls.io/builds/29225674) |
| :-- | --: |
| Change from base [Build 1032](https://coveralls.io/builds/29221949): | 0.0% |
| Covered Lines: | 12127 |
| Relevant Lines: | 20515 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4678:
Remove long sql test case
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4678: Remove long sql test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4678:
Remove long sql test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4678: Remove long sql test case
URL: https://github.com/apache/incubator-shardingsphere/pull/4678#issuecomment-596605536
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4678?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f9d84f4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4678?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4678 +/- ##
=========================================
Coverage ? 55.48%
Complexity ? 426
=========================================
Files ? 1134
Lines ? 20515
Branches ? 3805
=========================================
Hits ? 11383
Misses ? 8416
Partials ? 716
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4678?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4678?src=pr&el=footer). Last update [f9d84f4...418b993](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4678?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services