You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/14 21:36:05 UTC

[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #6296: GEODE-9136: make RedisData implement Sizeable

nonbinaryprogrammer commented on a change in pull request #6296:
URL: https://github.com/apache/geode/pull/6296#discussion_r613602859



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -145,13 +148,15 @@ private void shutDownHscanSnapshotScheduledRemoval() {
   public synchronized void toData(DataOutput out, SerializationContext context) throws IOException {
     super.toData(out, context);
     DataSerializer.writeHashMap(hash, out);
+    DataSerializer.writeInteger(hashSize.get(), out);

Review comment:
       from discussion with @ringles: it seems like writing it over the wire would save us some time recomputing the value. as the data set gets bigger, that could take us a good chunk of time. Is there a disadvantage to serializing it that we are not aware of?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org