[jira] [Commented] (ATLAS-1815) Exclude DELETED entities : Not all ACTIVE instances are returned when queried with limit 'n' even when more than 'n' ACTIVE instances are present.

["Sarath Subramanian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016459#comment-16016459 ] 

Sarath Subramanian commented on ATLAS-1815:
-------------------------------------------

The excludeDeleted entities logic were applied on the result of gremlin query leading to missing entities in result( that were deleted). The filter is now added as part of gremlin query to return only active/inactive entities based on flag.

> Exclude DELETED entities : Not all ACTIVE instances are returned when queried with limit 'n' even when more than 'n' ACTIVE instances are present.
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ATLAS-1815
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1815
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.9-incubating
>            Reporter: Sharmadha Sainath
>            Assignee: Sarath Subramanian
>            Priority: Critical
>
> "excludeDeletedEntities" filter is made after the response is returned, which produces unexpected results when limit keyword is used like in the following case :
> 1.Started fresh instance of Atlas and created 50 hive_tables
> 2. Made a basic search query , type name = hive_table which returned 50 tables in 2 pages in UI.
> Query fired : 
> {code}
> /api/atlas/v2/search/basic?limit=25&excludeDeletedEntities=true&typeName=hive_table
> {code}
> 3.Dropped the five tables which were shown as the first five results in the first page of basic search query results.
> 4. Made the same basic query again (type name = hive_table) .
> 5.Expected that 25 ACTIVE results would come up in the first page of UI. But only 20 results were displayed in the UI.
> 6. When "Include historical Entities" is checked , result table showed 20 ACTIVE tables and 5 DELETED tables.
> This happens because , probably when "limit=25&excludeDeletedEntities=true&typeName=hive_table" is fired ,
> first 25 results are returned (irrespective of ACTIVE or DELETED) and excludeDeletedEntities=true filter is applied which results in only 20 results. User would expect 25 tables to be returned in the UI since there are 45 ACTIVE tables but UI shows only 20 ACTIVE instances because of the "excludeDeletedEntities=true" filter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)