[jira] [Comment Edited] (OFBIZ-5057) Image rendering issue on productdetail.ftl

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481213#comment-13481213 ] 

Jacques Le Roux edited comment on OFBIZ-5057 at 12/20/14 11:58 AM:
-------------------------------------------------------------------

Well this is pretty weird since if_exist or ?? are both testing for null and not emptyness, while has_content is clerarly for testing emptyness. When you read all the definition above (I have fixed the link, FF was removing the protocol from urls and I finally got rif of that on my machine) there is more about the meaning of empty for has_content. Could you try by replacing (only) has_content with "!?length > 0"


was (Author: jacques.le.roux):
Well this is pretty weird since if_exist or ?? are both testing for null and not emptyness, while has_content is clerarly for testing emptyness. When you read all the definition above (I have fixed the link, FF was removing the protocol from urls and I [finally got rif of that on my machine|http://betashuffle.com/1602/force-firefox-http-part-visible-address-bar/]) there is more about the meaning of empty for has_content. Could you try by replacing (only) has_content with "!?length > 0"

> Image rendering issue on productdetail.ftl
> ------------------------------------------
>
>                 Key: OFBIZ-5057
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5057
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Trunk
>         Environment: FTL code, not relevant
>            Reporter: Carsten Schinzer
>            Priority: Minor
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Reference: Line 358
> !     <#if productImageList?has_content>
> A validation seems to have been introduced by rev. 1345532 where before on the FTL if clause, both checks (not null and hs content) were executed while now they are no longer. This leads to a failure to render of no related Content Images are on the Product but only attributed image URLs.
> 1     <#if productImageList?if_exists && productImageList?has_content>
> Does the trick, so would the earlier version:
> 2     <#if productImageList != null && productImageList?has_content>
> I also assume that with rev. 1345532 it was intended to put this here:
> 3     <#if productImageList?? && productImageList?has_content>
>  I leave it to the FTL pros to comment and recommend for ca. 24 hours.
>  If no comment by tomorrow, I shall propose to use the former code corresponding to [3] as this is what was the latest agreement made on OFBIZ-4916.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)