You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/15 12:49:13 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3219: ARTEMIS-2846 Cannot define hawtio.role with whitespace
brusdev opened a new pull request #3219:
URL: https://github.com/apache/activemq-artemis/pull/3219
Move the `hawtio.role` property definition to avoid the word splitting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3219: ARTEMIS-2846 Cannot define hawtio.role with whitespace
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3219:
URL: https://github.com/apache/activemq-artemis/pull/3219#issuecomment-663587542
@clebertsuconic I added a check for Artemis Jolokia REST API in artemis-distribution/src/test/scripts/validate-installation.sh and a test for the roles with spaces in org.apache.activemq.cli.test.ArtemisTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3219: ARTEMIS-2846 Cannot define hawtio.role with whitespace
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3219:
URL: https://github.com/apache/activemq-artemis/pull/3219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3219: ARTEMIS-2846 Cannot define hawtio.role with whitespace
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3219:
URL: https://github.com/apache/activemq-artemis/pull/3219#issuecomment-663217588
@brusdev it would probably be a good idea to change artemis-distribution/src/test/scripts/validate-installation.sh to do some testing with spaces on the role? is there a way we could increase coverage through such test?
I do use this test on our internal CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org