You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2025/07/17 14:01:08 UTC
[PR] API, Core: Avoid boxing of integer in evaluators / simplify ManifestReader [iceberg]
nastra opened a new pull request, #13589:
URL: https://github.com/apache/iceberg/pull/13589
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Avoid boxing of integer in evaluators / simplify ManifestReader [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #13589:
URL: https://github.com/apache/iceberg/pull/13589#discussion_r2213437792
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -256,11 +256,11 @@ private CloseableIterable<ManifestEntry<F>> entries(boolean onlyLive) {
}
private boolean hasRowFilter() {
- return rowFilter != null && rowFilter != Expressions.alwaysTrue();
Review Comment:
this has been already statically imported in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Avoid boxing of integer in evaluators / simplify ManifestReader [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #13589:
URL: https://github.com/apache/iceberg/pull/13589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Avoid boxing of integer in evaluators / simplify ManifestReader [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #13589:
URL: https://github.com/apache/iceberg/pull/13589#issuecomment-3085096793
Thanks @nastra for the cleanup and @stevenzwu @singhpk234 for reviewing, I'll go ahead and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Avoid boxing of integer in evaluators / simplify ManifestReader [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #13589:
URL: https://github.com/apache/iceberg/pull/13589#discussion_r2213437792
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -256,11 +256,11 @@ private CloseableIterable<ManifestEntry<F>> entries(boolean onlyLive) {
}
private boolean hasRowFilter() {
- return rowFilter != null && rowFilter != Expressions.alwaysTrue();
Review Comment:
this has been already statically imported in this class and from what I can tell the `rowFilter` and the `partFilter` can never be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org