You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tupshin Harper (JIRA)" <ji...@apache.org> on 2010/03/30 00:28:27 UTC
[jira] Created: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Add build.xml block to generate Thrift bindings for PHP.
--------------------------------------------------------
Key: CASSANDRA-927
URL: https://issues.apache.org/jira/browse/CASSANDRA-927
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.6
Reporter: Tupshin Harper
Priority: Minor
The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851402#action_12851402 ]
Eric Evans commented on CASSANDRA-927:
--------------------------------------
> But I don't really think we should proliferate these in our ant file. Java yes for obvious reasons, python yes for the system tests, but the others you really shouldn't be generating into the cassandra source tree imo.
I agree.
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Priority: Minor
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852402#action_12852402 ]
Ted Zlatanov commented on CASSANDRA-927:
----------------------------------------
You're right, thanks for cleaning the Perl target out.
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 927.txt
>
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852064#action_12852064 ]
Eric Evans commented on CASSANDRA-927:
--------------------------------------
+1
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Priority: Minor
> Attachments: 927.txt
>
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-927:
-------------------------------------
Attachment: 927.txt
As stated above, the cassandra source tree is not the place users should be generating bindings, and teaching them to use our build tool for a non-build-related operation is wrongheaded. Finally, "ant gen-thrift-perl" is hardly an improvement over "thrift -gen perl interface/cassandra.thrift".
Patch removing gen-thrift-perl attached.
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Priority: Minor
> Attachments: 927.txt
>
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851160#action_12851160 ]
Jonathan Ellis commented on CASSANDRA-927:
------------------------------------------
Seeing as how we have perl already I guess we should add this.
But I don't really think we should proliferate these in our ant file. Java yes for obvious reasons, python yes for the system tests, but the others you really shouldn't be generating into the cassandra source tree imo.
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Priority: Minor
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Ted Zlatanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852056#action_12852056 ]
Ted Zlatanov commented on CASSANDRA-927:
----------------------------------------
This is not a request to generate the source files, only to make it easier for the end users. So the source tree is only populated with language X if the end user needs it.
But since we're moving to Avro this will become much less important :)
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Priority: Minor
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-927) Add build.xml block to generate
Thrift bindings for PHP.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852361#action_12852361 ]
Hudson commented on CASSANDRA-927:
----------------------------------
Integrated in Cassandra #397 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/397/])
r/m gen-thrift-perl.
patch by jbellis; reviewed by eevans for
> Add build.xml block to generate Thrift bindings for PHP.
> --------------------------------------------------------
>
> Key: CASSANDRA-927
> URL: https://issues.apache.org/jira/browse/CASSANDRA-927
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tupshin Harper
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 927.txt
>
>
> The Ant build.xml file currently includes blocks to generate java, perl, and python bindings. The enclosed patch adds the ability to generate the php bindings directly from ant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.