You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:36:01 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #9915: fix: annotation layer json
etr2460 opened a new pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915
### SUMMARY
The `annotation_json` API makes use of the TableViz to structure the data returned from it. However, in https://github.com/apache/incubator-superset/pull/9122, we started limiting the columns that were returned, breaking this API. No one caught it because annotations were broken for a variety of other reasons, but I believe that this change should resolve all annotation layer issues remaining
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
<img width="1115" alt="Screen Shot 2020-05-26 at 11 44 42 AM" src="https://user-images.githubusercontent.com/7409244/82942624-19100580-9f4d-11ea-9f06-7543c26a0d2f.png">
### TEST PLAN
Test a chart with an annotation layer added and see the annotation display on the chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @john-bodley @graceguo-supercat @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634450656
Thanks for the test fix @john-bodley! I confirmed that the test fails without my fix, and works with it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=h1) Report
> Merging [#9915](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9915 +/- ##
==========================================
- Coverage 71.23% 71.20% -0.04%
==========================================
Files 585 585
Lines 30870 30742 -128
Branches 3239 3239
==========================================
- Hits 21990 21889 -101
+ Misses 8771 8744 -27
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.82% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
| #python | `71.35% <100.00%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.70% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `67.74% <0.00%> (-1.96%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.51% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/views/chart/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | `86.48% <0.00%> (-0.70%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `87.27% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=footer). Last update [2c97e72...3f7ca86](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=h1) Report
> Merging [#9915](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9915 +/- ##
==========================================
- Coverage 71.23% 70.95% -0.29%
==========================================
Files 585 585
Lines 30870 30742 -128
Branches 3239 3239
==========================================
- Hits 21990 21812 -178
- Misses 8771 8815 +44
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.96% <ø> (-0.87%)` | :arrow_down: |
| #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
| #python | `71.28% <100.00%> (-0.13%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.48% <100.00%> (-0.58%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=footer). Last update [2c97e72...3f7ca86](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=h1) Report
> Merging [#9915](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9915 +/- ##
==========================================
- Coverage 71.23% 71.16% -0.08%
==========================================
Files 585 585
Lines 30870 30742 -128
Branches 3239 3239
==========================================
- Hits 21990 21877 -113
+ Misses 8771 8756 -15
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.82% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
| #python | `71.28% <100.00%> (-0.13%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.48% <100.00%> (-0.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `67.74% <0.00%> (-1.96%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.51% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=footer). Last update [2c97e72...3f7ca86](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=h1) Report
> Merging [#9915](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `4.95%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9915 +/- ##
==========================================
- Coverage 71.23% 66.27% -4.96%
==========================================
Files 585 585
Lines 30870 30744 -126
Branches 3239 3239
==========================================
- Hits 21990 20377 -1613
- Misses 8771 10188 +1417
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (ø)` | |
| #python | `71.14% <0.00%> (-0.27%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <0.00%> (-1.18%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=footer). Last update [2c97e72...53cc2e4](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=h1) Report
> Merging [#9915](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9915 +/- ##
==========================================
- Coverage 71.23% 71.09% -0.14%
==========================================
Files 585 184 -401
Lines 30870 18002 -12868
Branches 3239 0 -3239
==========================================
- Hits 21990 12799 -9191
+ Misses 8771 5203 -3568
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.09% <100.00%> (-0.32%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.48% <100.00%> (-0.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| ... and [425 more](https://codecov.io/gh/apache/incubator-superset/pull/9915/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=footer). Last update [2c97e72...3f7ca86](https://codecov.io/gh/apache/incubator-superset/pull/9915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
etr2460 edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634387543
@john-bodley, I tried my best to add a test here, but wasn't able to get it to work due to an issue (maybe with FAB?). Here's my test code (also added in a commit to this PR):
```python
def test_annotation_json_endpoint(self):
# Something is broken with annotations and RLS, teardown will undo this
app.config["ENABLE_ROW_LEVEL_SECURITY"] = False
self.login(username="admin")
# Set up an annotation layer and annotation
self.get_resp(
"/annotationlayermodelview/add",
{"form_data": json.dumps({"name": "foo", "descr": "bar"})},
)
self.get_resp(
"/annotationmodelview/add",
{
"form_data": json.dumps(
{
"layer": "1",
"short_descr": "my_annotation",
"start_dttm": "2020-05-20 18:21:51",
"end_dttm": "2020-05-20 18:31:51",
}
)
},
)
resp = self.get_resp(
"/superset/annotation_json/1?form_data=%7B%22time_range%22%3A%22100+years+ago+%3A+now%22%7D"
)
assert "my_annotation" in resp
```
And the error I saw:
```
======================================================================
ERROR: test_annotation_json_endpoint (tests.core_tests.CoreTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/erik_ritter/repos/github.com/incubator-superset/tests/core_tests.py", line 208, in test_annotation_json_endpoint
"end_dttm": "2020-05-20 18:31:51",
File "/Users/erik_ritter/repos/github.com/incubator-superset/tests/base_tests.py", line 191, in get_resp
resp = self.client.post(url, data=data, follow_redirects=follow_redirects)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/werkzeug/test.py", line 1039, in post
return self.open(*args, **kw)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/testing.py", line 227, in open
follow_redirects=follow_redirects,
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/werkzeug/test.py", line 993, in open
response = self.run_wsgi_app(environ.copy(), buffered=buffered)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/werkzeug/test.py", line 884, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/werkzeug/test.py", line 1119, in run_wsgi_app
app_rv = app(environ, start_response)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 2463, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 2449, in wsgi_app
response = self.handle_exception(e)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 1866, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py", line 109, in wraps
return f(self, *args, **kwargs)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/views.py", line 589, in add
self.add_template, title=self.add_title, widgets=widget
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/baseviews.py", line 281, in render_template
template, **dict(list(kwargs.items()) + list(self.extra_args.items()))
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/templating.py", line 140, in render_template
ctx.app,
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask/templating.py", line 120, in _render
rv = template.render(context)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
return original_render(self, *args, **kwargs)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
return self.environment.handle_exception(exc_info, True)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
raise value.with_traceback(tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/add.html", line 2, in top-level template code
{% import 'appbuilder/general/lib.html' as lib %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/base.html", line 1, in top-level template code
{% extends base_template %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/superset/templates/superset/base.html", line 20, in top-level template code
{% from 'superset/partials/asset_bundle.html' import css_bundle, js_bundle with context %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/superset/templates/appbuilder/baselayout.html", line 20, in top-level template code
{% import 'appbuilder/baselib.html' as baselib %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/init.html", line 46, in top-level template code
{% block body %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/superset/templates/appbuilder/baselayout.html", line 39, in block "body"
{% block content %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/add.html", line 7, in block "content"
{% block add_form %}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/add.html", line 8, in block "add_form"
{{ widgets.get('add')(form_action=form_action)|safe }}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/widgets.py", line 37, in __call__
return template.render(args)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
return original_render(self, *args, **kwargs)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
return self.environment.handle_exception(exc_info, True)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
raise value.with_traceback(tb)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/form.html", line 45, in top-level template code
{{ lib.render_field(field, begin_sep_label, end_sep_label, begin_sep_field, end_sep_field) }}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/jinja2/runtime.py", line 574, in _invoke
rv = self._func(*arguments)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/lib.html", line 233, in template
{{ field(**kwargs)|safe }}
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/wtforms/fields/core.py", line 155, in __call__
return self.meta.render_field(self, kwargs)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/wtforms/meta.py", line 56, in render_field
return field.widget(field, **render_kw)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/flask_appbuilder/fieldwidgets.py", line 156, in __call__
return super(Select2Widget, self).__call__(field, **kwargs)
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/wtforms/widgets/core.py", line 324, in __call__
html.append(self.render_option(val, label, selected))
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/wtforms/widgets/core.py", line 337, in render_option
return HTMLString('<option %s>%s</option>' % (html_params(**options), escape_html(label, quote=False)))
File "/Users/erik_ritter/repos/github.com/incubator-superset/.tox/py36/lib/python3.6/site-packages/wtforms/widgets/core.py", line 31, in escape_html
s = escape(text_type(s), quote=quote)
TypeError: __str__ returned non-string (type NoneType)
```
It looks like when I'm trying to create an annotation inside the annotation layer, it's rendering a template instead of creating the new annotation. Maybe @dpgaspar has thoughts here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634277786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9915: fix: annotation layer json
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9915:
URL: https://github.com/apache/incubator-superset/pull/9915#issuecomment-634236766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org