[jira] [Updated] (PIG-4833) TestBuiltin.testURIWithCurlyBrace in TEZ failing after PIG-4819

["Koji Noguchi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Noguchi updated PIG-4833:
------------------------------
    Attachment: pig-4833-v01.patch

This was weird to me since my patch in PIG-4819 didn't touch {{TestBuiltin.testURIWithCurlyBrace}} at all.

Looking further, it seems like an issue with tez test environment when local mode and mapreduce/tez mode are intermixed.  Test code does call {{Util. resetStateForExecModeSwitch()}}, which states 

{code:title=Util.java}
  1337     /**
  1338      * Called to reset ThreadLocal or static states that PigServer depends on
  1339      * when a test suite has testcases switching between LOCAL and MAPREDUCE/TEZ
  1340      * execution modes
  1341      */
  1342     public static void resetStateForExecModeSwitch() {
{code}

but {{TezResourceManager}} caches an instance from PIG-3978 and would not re-initialize when we move from tez mode to local mode.  Uploading a patch, pig-4833-v01.patch,  that explicitly drops this instance for every Util.resetStateForExecModeSwitch call.
Not sure if adding a public method just for testing is justified or not.  

Besides from this issue, made minor changes in {{testUniqueID}} and {{testRANDOMWithJob}} in TestBuiltin.java to 
* use its own copy for setting PigServer properties.
* delete the input file when test is done.

These minor changes were things I've tried before finding out the issue above.


> TestBuiltin.testURIWithCurlyBrace in TEZ failing after PIG-4819
> ---------------------------------------------------------------
>
>                 Key: PIG-4833
>                 URL: https://issues.apache.org/jira/browse/PIG-4833
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Koji Noguchi
>            Assignee: Koji Noguchi
>            Priority: Minor
>         Attachments: pig-4833-v01.patch
>
>
> From https://issues.apache.org/jira/browse/PIG-4819?focusedCommentId=15179448#comment-15179448
> {quote}
> TestBuiltin.testURIWithCurlyBrace is failing after addition of testRandomJob with -Dhadoopversion=23 -Dexectype=tez. Possible to take a look at it? 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)