Re: Review Request 24970: SENTRY-393 Grant/Revoke and Show Grant info support for column level privilege

[Prasad Mujumdar <pr...@cloudera.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24970/#review60647
-----------------------------------------------------------

Ship it!


Looks fine.

- Prasad Mujumdar


On Oct. 29, 2014, 7:41 a.m., Dapeng Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24970/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 7:41 a.m.)
> 
> 
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The patch include:
> * Remove the limit for column in SentryGrantRevokeTask
> * Get column list info in SentryGrantRevokeTask
> * Save column list in SentryHivePrivilegeObjectDesc
> * SHOW GRANT support and add e2e test for SHOW GRANT
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 6f83cc6 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java ac45746 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 1b5f557 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java f38ee91 
>   sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 38fa69e 
> 
> Diff: https://reviews.apache.org/r/24970/diff/
> 
> 
> Testing
> -------
> 
> Unit tests in local
> 
> 
> Thanks,
> 
> Dapeng Sun
> 
>