You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/02/14 20:29:34 UTC

Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56679/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-20016
    https://issues.apache.org/jira/browse/AMBARI-20016


Repository: ambari


Description
-------

STR:
On a 1000-node cluster, go to Hosts page
Set the page size to 100 (shows hosts 1-100)
Using the paging controls, go to the next page (shows hosts 101-200) - this takes several seconds
Using the paging controls, go to the next page (shows hosts 201-300) - this takes longer
Repeat showing the next set of hosts. This gets progressively slower. I gave up when I hit 701-800 since the page got totally stuck after waiting for 3 minutes.


Diffs
-----

  ambari-web/app/controllers/main.js 87a483e 
  ambari-web/app/controllers/main/service/add_controller.js f312a5a 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 4cf22d4 
  ambari-web/app/controllers/wizard/step7_controller.js 1d24ee3 
  ambari-web/app/mappers/alert_definition_summary_mapper.js 8b59c7c 
  ambari-web/app/mappers/alert_definitions_mapper.js c400b89 
  ambari-web/app/mappers/alert_groups_mapper.js c079c21 
  ambari-web/app/mappers/alert_instances_mapper.js 269941b 
  ambari-web/app/mappers/alert_notification_mapper.js 9567c77 
  ambari-web/app/mappers/cluster_mapper.js 5689867 
  ambari-web/app/mappers/components_state_mapper.js 89d5af2 
  ambari-web/app/mappers/configs/config_groups_mapper.js fe3d7a1 
  ambari-web/app/mappers/configs/service_config_version_mapper.js 68bf235 
  ambari-web/app/mappers/configs/themes_mapper.js 8ad51bd 
  ambari-web/app/mappers/hosts_mapper.js 3c7dd70 
  ambari-web/app/mappers/quicklinks_mapper.js 6cb1fe0 
  ambari-web/app/mappers/repository_version_mapper.js 48e460b 
  ambari-web/app/mappers/root_service_mapper.js 1e0e070 
  ambari-web/app/mappers/server_data_mapper.js a99d8ae 
  ambari-web/app/mappers/service_mapper.js 9a330f9 
  ambari-web/app/mappers/service_metrics_mapper.js c4f37df 
  ambari-web/app/mappers/stack_mapper.js b1a5faf 
  ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
  ambari-web/app/mappers/stack_upgrade_history_mapper.js 823ae80 
  ambari-web/app/mappers/stack_version_mapper.js bd37288 
  ambari-web/app/mappers/target_cluster_mapper.js f774213 
  ambari-web/app/mappers/users_mapper.js 80d7feb 
  ambari-web/app/mappers/widget_mapper.js 0991d4f 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 93dea5f 
  ambari-web/app/mixins/main/service/groups_mapping.js 0781aa3 
  ambari-web/app/models/user.js 4dde8ec 
  ambari-web/app/utils/http_client.js 9b8346c 
  ambari-web/test/controllers/main/admin_test.js b2828d0 
  ambari-web/test/controllers/main/host/details_test.js 17b1eec 
  ambari-web/test/controllers/main/service/add_controller_test.js 715f46a 
  ambari-web/test/controllers/main/service/item_test.js 6430ab6 
  ambari-web/test/mappers/alert_groups_mapper_test.js 9480e3d 
  ambari-web/test/mixins/main/service/configs/config_overridable_test.js b1eb099 
  ambari-web/test/models/host_component_test.js d577005 
  ambari-web/test/models/host_stack_version_test.js 702e284 
  ambari-web/test/models/rack_test.js a63eaba 
  ambari-web/test/models/stack_service_test.js bc101e0 
  ambari-web/test/utils/http_client_test.js 589c44e 

Diff: https://reviews.apache.org/r/56679/diff/


Testing
-------

20340 passing (34s)
  153 pending


Thanks,

Andrii Tkach


Re: Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56679/#review165701
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On \u0424\u0435\u0432. 14, 2017, 8:29 \u043f.\u043f., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56679/
> -----------------------------------------------------------
> 
> (Updated \u0424\u0435\u0432. 14, 2017, 8:29 \u043f.\u043f.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20016
>     https://issues.apache.org/jira/browse/AMBARI-20016
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> On a 1000-node cluster, go to Hosts page
> Set the page size to 100 (shows hosts 1-100)
> Using the paging controls, go to the next page (shows hosts 101-200) - this takes several seconds
> Using the paging controls, go to the next page (shows hosts 201-300) - this takes longer
> Repeat showing the next set of hosts. This gets progressively slower. I gave up when I hit 701-800 since the page got totally stuck after waiting for 3 minutes.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main.js 87a483e 
>   ambari-web/app/controllers/main/service/add_controller.js f312a5a 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 4cf22d4 
>   ambari-web/app/controllers/wizard/step7_controller.js 1d24ee3 
>   ambari-web/app/mappers/alert_definition_summary_mapper.js 8b59c7c 
>   ambari-web/app/mappers/alert_definitions_mapper.js c400b89 
>   ambari-web/app/mappers/alert_groups_mapper.js c079c21 
>   ambari-web/app/mappers/alert_instances_mapper.js 269941b 
>   ambari-web/app/mappers/alert_notification_mapper.js 9567c77 
>   ambari-web/app/mappers/cluster_mapper.js 5689867 
>   ambari-web/app/mappers/components_state_mapper.js 89d5af2 
>   ambari-web/app/mappers/configs/config_groups_mapper.js fe3d7a1 
>   ambari-web/app/mappers/configs/service_config_version_mapper.js 68bf235 
>   ambari-web/app/mappers/configs/themes_mapper.js 8ad51bd 
>   ambari-web/app/mappers/hosts_mapper.js 3c7dd70 
>   ambari-web/app/mappers/quicklinks_mapper.js 6cb1fe0 
>   ambari-web/app/mappers/repository_version_mapper.js 48e460b 
>   ambari-web/app/mappers/root_service_mapper.js 1e0e070 
>   ambari-web/app/mappers/server_data_mapper.js a99d8ae 
>   ambari-web/app/mappers/service_mapper.js 9a330f9 
>   ambari-web/app/mappers/service_metrics_mapper.js c4f37df 
>   ambari-web/app/mappers/stack_mapper.js b1a5faf 
>   ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
>   ambari-web/app/mappers/stack_upgrade_history_mapper.js 823ae80 
>   ambari-web/app/mappers/stack_version_mapper.js bd37288 
>   ambari-web/app/mappers/target_cluster_mapper.js f774213 
>   ambari-web/app/mappers/users_mapper.js 80d7feb 
>   ambari-web/app/mappers/widget_mapper.js 0991d4f 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 93dea5f 
>   ambari-web/app/mixins/main/service/groups_mapping.js 0781aa3 
>   ambari-web/app/models/user.js 4dde8ec 
>   ambari-web/app/utils/http_client.js 9b8346c 
>   ambari-web/test/controllers/main/admin_test.js b2828d0 
>   ambari-web/test/controllers/main/host/details_test.js 17b1eec 
>   ambari-web/test/controllers/main/service/add_controller_test.js 715f46a 
>   ambari-web/test/controllers/main/service/item_test.js 6430ab6 
>   ambari-web/test/mappers/alert_groups_mapper_test.js 9480e3d 
>   ambari-web/test/mixins/main/service/configs/config_overridable_test.js b1eb099 
>   ambari-web/test/models/host_component_test.js d577005 
>   ambari-web/test/models/host_stack_version_test.js 702e284 
>   ambari-web/test/models/rack_test.js a63eaba 
>   ambari-web/test/models/stack_service_test.js bc101e0 
>   ambari-web/test/utils/http_client_test.js 589c44e 
> 
> Diff: https://reviews.apache.org/r/56679/diff/
> 
> 
> Testing
> -------
> 
> 20340 passing (34s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>