You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/11/04 21:12:11 UTC

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman opened a new pull request #2: SLING-10911 Update to Parent 46

enapps-enorman opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2


   Update to the latest parent so the module can be built with java 11
   
   Also migration to the standard scr annotations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] kwin commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743410420



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Every versioned package is automatically exported

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       No need for this non-standard header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] removed a comment on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman merged pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] removed a comment on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961477363


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-962137650


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961477363


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] kwin commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743410420



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Every versioned package is automatically exported

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       No need for this non-standard header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] removed a comment on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] removed a comment on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961488087


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] kwin commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743966204



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       No need for removing, just go with the standard value for `Private-Package` as generated by bnd.

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       No need for removing, just go with the standard value for `Private-Package` as generated by bnd and remove it from this `bnd.bnd`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743907754



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.  And yes, you are correct, but only one of those exported packages contained a package-info.java file so a little more work is needed here.
   
   I have cleaned this up by adding a package-info.java file to the other two packages and removed this instruction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743907754



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.  And yes, you are correct, but only one of those exported packages contained a package-info.java file so a little more work is needed here.
   
   I have cleaned this up by adding a package-info.java file to the other two packages and removed this instruction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] kwin commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743410420



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Every versioned package is automatically exported

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       No need for this non-standard header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743929577



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.   I don't have a problem removing this instruction as it doesn't appear to have any impact on running the tests.
   
   However, I would note that removing this instruction doesn't prevent this attribute from showing up in the generated manifest as bnd would just use the default configuration.
   
   I've seen a few places using the "removeheaders" instruction to remove it from the output, is this what you were expecting?
   
   -removeheaders:\
     Private-Package
   

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.   I don't have a problem removing this instruction as it doesn't appear to have any impact on running the tests.
   
   However, I would note that removing this instruction doesn't prevent this attribute from showing up in the generated manifest as bnd would just use the default configuration.
   
   I've seen a few places using the "removeheaders" instruction to remove it from the output, is this what you were expecting?
   
   -removeheaders: Private-Package
   

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.  And yes, you are correct, but only one of those exported packages contained a package-info.java file so a little more work is needed here.
   
   I have cleaned this up by adding a package-info.java file to the other two packages and removed this instruction.

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.   I don't have a problem removing this instruction as it doesn't appear to have any impact on running the tests.
   
   However, I would note that removing this instruction doesn't prevent this attribute from showing up in the generated manifest as bnd would just use the default configuration.
   
   I've seen a few places using the "removeheaders" instruction to remove it from the output, is this what you were expecting?
   
   -removeheaders:\
     Private-Package
   

##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       Thanks for the review.  This was a direct copy of how the old maven-bundle-plugin instructions were doing it.   I don't have a problem removing this instruction as it doesn't appear to have any impact on running the tests.
   
   However, I would note that removing this instruction doesn't prevent this attribute from showing up in the generated manifest as bnd would just use the default configuration.
   
   I've seen a few places using the "removeheaders" instruction to remove it from the output, is this what you were expecting?
   
   -removeheaders: Private-Package
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] removed a comment on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961488087


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#issuecomment-961429027


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-test-services&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-launchpad-test-services] enapps-enorman commented on a change in pull request #2: SLING-10911 Update to Parent 46

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/2#discussion_r743981998



##########
File path: bnd.bnd
##########
@@ -0,0 +1,28 @@
+Export-Package:\
+  org.apache.sling.launchpad.testservices.exported,\
+  org.apache.sling.launchpad.testservices.models,\
+  org.apache.sling.launchpad.testservices.events
+
+Private-Package:\

Review comment:
       fair enough.  This was already done with the last commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org