[jira] [Commented] (PIVOT-721) ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style

["Bill van Melle (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010874#comment-13010874 ] 

Bill van Melle commented on PIVOT-721:
--------------------------------------

Oops, there's one more thing to fix.  Once you make the BoxPane fill, its verticalAlignment style is ignored.  So you need to make its components align:

        label.getStyles().put("verticalAlignment", VerticalAlignment.CENTER);
        imageView.getStyles().put("verticalAlignment", VerticalAlignment.CENTER);

and with that, presumably you can get rid of the verticalAlignment style on the BoxPane itself (as well as the horizontalAlignment, for which it's unclear why it was even there).



> ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't have fill style
> -----------------------------------------------------------------------------------------
>
>                 Key: PIVOT-721
>                 URL: https://issues.apache.org/jira/browse/PIVOT-721
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: Bill van Melle
>            Priority: Minor
>
> ButtonDataRenderer has a setFillIcon method, which supposedly should allow the button's image to be scaled to fit the button.  However, it has no effect, because the renderer is a BoxPane with the default fill=false.
> Fix: In the ButtonDataRenderer constructor, add
>     getStyles().put("fill", true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira