[jira] [Commented] (AIRFLOW-5045) Add ability to create Google Dataproc cluster with custom image from a different project

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902371#comment-16902371 ] 

ASF GitHub Bot commented on AIRFLOW-5045:
-----------------------------------------

idralyuk commented on pull request #5752: [AIRFLOW-5045] Add ability to create Google Dataproc cluster with cus…
URL: https://github.com/apache/airflow/pull/5752
 
 
   …tom image from a different project
   
   ### Jira
   
   https://issues.apache.org/jira/browse/AIRFLOW-5045
   
   ### Description
   
   [AIRFLOW-2797](https://github.com/apache/airflow/pull/3871) added functionality to create Dataproc clusters with custom images. Unfortunately the images can only be defined in the current project. This PR adds ability to define a custom image project.
   
   For more info see: https://cloud.google.com/dataproc/docs/guides/dataproc-images
   
   ### Tests
   
   One test added:
   
   it checks whether the custom image project id was set correctly
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add ability to create Google Dataproc cluster with custom image from a different project
> ----------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5045
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5045
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, gcp, operators
>    Affects Versions: 1.10.3
>            Reporter: Igor
>            Assignee: Igor
>            Priority: Minor
>
> Custom image support has been added for Dataproc by https://issues.apache.org/jira/browse/AIRFLOW-2797.
> Unfortunately the code assumes that the images come from the same project.
> It would be useful to add a new parameter 'custom_image_project_id' to specify the source project of the image.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)